Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v2.2.0 #274

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

Dragorn421
Copy link
Contributor

Can also use this PR to discuss the release (e.g. if we should wait for anything)

Yanies mentioned it may be good to wait for f3dex3 preview, but since that's not anywhere near ready afaik I think it's fine to have a release in between

It's been 2 years since the previous release 😅

If you have permission (I'm not sure who does) there is a release draft for 2.2.0 on the releases page https://github.com/Fast-64/fast64/releases (not visible by everyone apparently)

@Dragorn421 Dragorn421 changed the title Bump bl_info version to v2.2.0 Bump version to v2.2.0 Jan 5, 2024
Lilaa3
Lilaa3 previously approved these changes Jan 5, 2024
Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sauren said the f3dex3 preview stuff is gonna take awhile.

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Jan 5, 2024

Change-log looks perfect too!

@ariahiro64
Copy link

there is a major bug with map importer for oot that applies the scene function to every single material causing almost guaranteed crashes. it is NOT ready for a release in this state.

@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label Jan 5, 2024
@Lilaa3 Lilaa3 dismissed their stale review January 5, 2024 17:25

2.2.0 should be stable first. Didn´t know about any big oot issues.

@ariahiro64
Copy link

#252 the work around is there for the issue so i guess you guys now know where to point people with issues

@Dragorn421
Copy link
Contributor Author

there is a major bug with map importer for oot that applies the scene function to every single material causing almost guaranteed crashes. it is NOT ready for a release in this state.

Overlooking this because

  • it is not a major bug (exporting imported stuff is inherently fragile, and also not the primary goal of fast64)
  • though it's a pain you can fix the materials manually
  • afaik this isn't a regression, the issue has existed since scene importing was implemented
  • the 2.1.0 release already had scene importing (so, including the issue)

I am not trying to start an argument at all, just explaining why releasing despite this comment.

@ariahiro64
Copy link

there is a major bug with map importer for oot that applies the scene function to every single material causing almost guaranteed crashes. it is NOT ready for a release in this state.

Overlooking this because

* it is not a major bug (exporting imported stuff is inherently fragile, and also not the primary goal of fast64)

* though it's a pain you can fix the materials manually

* afaik this isn't a regression, the issue has existed since scene importing was implemented

* the 2.1.0 release already had scene importing (so, including the issue)

I am not trying to start an argument at all, just explaining why releasing despite this comment.

To add on we've also discussed it on the discord server and we feel just making people aware of the workaround is enough

Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its only an issue with imported scenes then I guess that is perfectly fine. Reverting my reverting of my approval!!

Copy link
Contributor

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we have an actual fix I'd like to see #275 merged before releasing 2.2.0, otherwise I don't have any objections

@Dragorn421
Copy link
Contributor Author

since we have an actual fix I'd like to see #275 merged before releasing 2.2.0, otherwise I don't have any objections

I think it will take a bit more time to find a proper fix, so in agreement with Yanies we're going to release as is

@Dragorn421 Dragorn421 merged commit 8774431 into Fast-64:main Jan 6, 2024
@Dragorn421 Dragorn421 deleted the bump_ver_v2.2.0 branch January 6, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants