-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to v2.2.0 #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sauren said the f3dex3 preview stuff is gonna take awhile.
Change-log looks perfect too! |
there is a major bug with map importer for oot that applies the scene function to every single material causing almost guaranteed crashes. it is NOT ready for a release in this state. |
2.2.0 should be stable first. Didn´t know about any big oot issues.
#252 the work around is there for the issue so i guess you guys now know where to point people with issues |
Overlooking this because
I am not trying to start an argument at all, just explaining why releasing despite this comment. |
To add on we've also discussed it on the discord server and we feel just making people aware of the workaround is enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its only an issue with imported scenes then I guess that is perfectly fine. Reverting my reverting of my approval!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have an actual fix I'd like to see #275 merged before releasing 2.2.0, otherwise I don't have any objections
I think it will take a bit more time to find a proper fix, so in agreement with Yanies we're going to release as is |
Can also use this PR to discuss the release (e.g. if we should wait for anything)
Yanies mentioned it may be good to wait for f3dex3 preview, but since that's not anywhere near ready afaik I think it's fine to have a release in between
It's been 2 years since the previous release 😅
If you have permission (I'm not sure who does) there is a release draft for 2.2.0 on the releases page https://github.com/Fast-64/fast64/releases (not visible by everyone apparently)