Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RunSummaryTable and OverviewMetrics code #834

Closed
crazyplayy opened this issue Sep 22, 2023 · 0 comments · Fixed by #835
Closed

Refactor RunSummaryTable and OverviewMetrics code #834

crazyplayy opened this issue Sep 22, 2023 · 0 comments · Fixed by #835
Assignees
@crazyplayy
Labels
enhancement Enhancement of an existing feature frontend refactoring
Milestone
v1.0.0

Comments

@crazyplayy
Copy link
Contributor

Description

There's a lot of code repetition between these two files. Besides, both are making calls to the API returning the same information

Solution

Refactor the code in both classes and create a new one that makes the API calls and returns the values to both classes
@crazyplayy crazyplayy added enhancement Enhancement of an existing feature refactoring frontend labels Sep 22, 2023
@crazyplayy crazyplayy added this to the v1.0.0 milestone Sep 22, 2023
@crazyplayy crazyplayy self-assigned this Sep 22, 2023
@crazyplayy crazyplayy linked a pull request Sep 26, 2023 that will close this issue
Feat: Reduce API calls while running a test #835
Merged
3 tasks
@crazyplayy crazyplayy mentioned this issue Sep 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crazyplayy crazyplayy

Labels
enhancement Enhancement of an existing feature frontend refactoring
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Feat: Reduce API calls while running a test Farfetch/maestro
1 participant
@crazyplayy