Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Endpoint won't show again when deselecting it in Endpoints chart #741

Open
crazyplayy opened this issue Jul 14, 2023 · 0 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@crazyplayy
Copy link
Contributor

Expected behavior

If we access a label endpoint chart via the Summary tab, it will show up as the only endpoint selected on the Endpoint tab

Actual behavior

After deselecting a label in the Endpoints tab, if we try to acess it again via the button on Summary tab, the label will not show as Selected again.

Steps to reproduce

  1. Start a test
  2. Acces the Summary tab
  3. Choose an ednpoint and click on the icon button on the right to taeyou to the Endpoint tab
  4. In the Ednpoints tab, deselect the label
  5. Return to Summary tab and repeat 3.
  6. The label will not be selected

Additional information

This happens because the label endpoint being sent to be displayed on the Endpoints tab is the same. Since its being used an useEffect in RunEndpointsChart.js to evaluate if a label endpoint is being received, when we sent it the second time, the value is equal to the previous one, so the useEffect isn't triggered, so the label to be displayed is not triggered and the empty array set by deselecting the label is maintained.

Possible fix

Evaluate the label endpoint always even if the value is the same

@crazyplayy crazyplayy added the bug Something isn't working label Jul 14, 2023
@crazyplayy crazyplayy added this to the v1.0.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant