-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation based on models #29
Comments
Have a warn or error on validation against a model. This would support sharing "partial" BPX files where all the fields are valid and consistent but not all the required parameters are there for any given model. Useful for e.g. sharing parameters fro a single electrode. SEe #40 |
Do we have a standard specification document that says which parameters need to be defined for which models? This is implied by Ferran's paper on which the original BPX (DFN) is based, but I think we need to express it formally before we can define the correctness or otherwise of the implementation in #34 . @ikorotkin Did you make such a specification document? Otherwise I can put one together. |
done in #34 |
Checking for required parameters should be done by model (e.g. SPM needs fewer parameters than DFN). Allows users to share "partial" BPX that is sufficient for reduced models.
The text was updated successfully, but these errors were encountered: