Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify winetricks choices #170

Open
n8marti opened this issue Sep 14, 2024 · 1 comment
Open

Simplify winetricks choices #170

n8marti opened this issue Sep 14, 2024 · 1 comment
Assignees
Labels
installer This issue is related to the install routine maintenance winetricks
Milestone

Comments

@n8marti
Copy link
Collaborator

n8marti commented Sep 14, 2024

It seems unlikely that winetricks would be used anywhere other than 1) downloaded by LLI to the INSTALLDIR/data/bin folder or 2) installed at the system level. Attempting to handle an arbitrary path, then, for WINETRICKSBIN could lead to more maintenance effort than is worth it.

Proposal: Only allow two options for WINETRICKSBIN: "default"/"download" or "system". Or, even simpler, leave it undefined for the default value, or accept "system" if the user wants to override that with the system version. In order to be backwards compatible, though, we would need a conversion function to convert legacy paths to either "system" or "default".

@n8marti n8marti added this to the Beta milestone Sep 14, 2024
@n8marti n8marti self-assigned this Sep 14, 2024
@thw26 thw26 added installer This issue is related to the install routine winetricks labels Sep 28, 2024
@thw26 thw26 modified the milestones: Beta, Release 1.0.0 Oct 4, 2024
@n8marti
Copy link
Collaborator Author

n8marti commented Oct 19, 2024

I've discovered that our wine appimage actually includes winetricks. So an even further simplification would be that "default" uses that one, while "custom" could be an arbitrary path given by the user. I think this choice only matters to developers/testers, so I would prefer to not even include it in the GUI, which would just automatically use the appimage winetricks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer This issue is related to the install routine maintenance winetricks
Projects
None yet
Development

No branches or pull requests

2 participants