Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when WebView is missing #69

Open
Madis0 opened this issue Oct 21, 2024 · 5 comments
Open

Throw error when WebView is missing #69

Madis0 opened this issue Oct 21, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Madis0
Copy link
Member

Madis0 commented Oct 21, 2024

Ideally on any platform

@Madis0 Madis0 added the enhancement New feature or request label Oct 21, 2024
@vgskye
Copy link
Collaborator

vgskye commented Oct 21, 2024

system webview is:

@vgskye
Copy link
Collaborator

vgskye commented Oct 21, 2024

I'm thinking installing WebView2 Runtime after asking the user if it is not present

@Madis0
Copy link
Member Author

Madis0 commented Oct 21, 2024

I'm thinking installing WebView2 Runtime after asking the user if it is not present

By "installing" you mean running the official installer as headless? I'm thinking that we could just give the user the installer link, so that we don't have to deal with

  • system files
  • admin permissions
  • probable restart after installation

@vgskye
Copy link
Collaborator

vgskye commented Oct 21, 2024

WebView2 Runtime installers are designed to run headlessly for this exact purpose so it should be fine?

@Madis0
Copy link
Member Author

Madis0 commented Oct 21, 2024

I thought that if we use the headless part, we still have to get the admin perm and handle restart ourselves. But I guess you're right, we can test and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants