Making non-fullCube blocks opaque

[sprucerooth]

I've been scratching my head and debugging this for a few days now.

I have a custom block with a less than full cuboid outline shape (a vertical slab). How can I make it be opaque?

As soon as I override AbstractBlock.getOutlineShape to return anything else than a VoxelShapes.fullCube, the block lets light pass through it.

[Technici4n]

If I recall correctly, you can override a method in your block, like getOpacity. There may also be something in the block settings.

[sprucerooth]

Thank you ! That was it. Silly that I missed that one.

One issue still remains with the lighting.

This is a wall of vertical slabs with the last piece missing:

When I place the last slab, the room now turns dark as it should. However, there is a slight light bleed from outside on the remaining half of the adjacent blocks (the slab takes up one half).

Also, if I turn off smooth lighting, this happens:

The part of the adjacent blocks that are dark here is also the area where the light bleed happens in the second image.

So what kind of light related fix might I be missing?

[warjort]

I am far from an expert on this, but have you got something like the following for your block?

   @Override
   public boolean hasSidedTransparency(BlockState state) {
      return true;
   }

Most of the vanilla blocks that are not full cubes change this property. e.g. the vanilla slab does:

   public boolean hasSidedTransparency(BlockState state) {
      return state.get(TYPE) != SlabType.DOUBLE;
   }

i.e. it is false when the double slab occupies the full block, true for half slabs.

[sprucerooth]

I noticed that as well and I tried it but no luck :/ I'm not really sure what sided transparency means.

[sprucerooth]

I could find a similar problem in Forge on 1.12:
https://forums.minecraftforge.net/topic/63248-112-half-slabs-display-issue-when-smooth-lighting-is-off/

Might be completely irrelevant since it's Forge and an older version.

[warjort]

I noticed that as well and I tried it but no luck :/ I'm not really sure what sided transparency means.

I believe it is used to do extra checks for lighting updates. I suggested it because other non full cube blocks change it.

My guess would be that you have some mismatch between the block model and getOutlineShape(), e.g. the coordinates of your shape or the culled faces. But like I said above, I am no expert on rendering.

Maybe you can post the block model and definition for your getOutlineShape()? More eyes might see an error if there is one.

I would also suggest to compare your code against vanilla's SlabBlock and its block models. Your block sounds similar to it?

[sprucerooth]

Well the model and the outlines match up. Of course I could be missing something but I don't think that's the issue.
Yeah I have studied SlabBlock before as well but I can't find any code that seems to be related to that.

I tested the same thing but using tinted glass, which is supposed to block light.
Here I have disabled smooth lighting. The dark areas are there as they were with my slabs(though covered with the transparent glass block):

And if I enable smooth lighting:

As you can see that light gradient/bleed is there on the adjacent blocks, just like with my vertical slabs. Only now the adjacent blocks are completely covered by the tinted glass block since its a full cube.

So the behaviour seems intended.
However this does not happen on regular slabs so there has to be a way to disable it!