OreDict entry creation has no input validation

[elifoster]

The creation functionality does not perform any checks against the data provided so you can literally put nothing and it will create an entry.

[Alexia]

I will hold off deploying the current OreDict until this is ready.

[elifoster]

Hm. Upon further investigation this is actually true for the ImportOreDict page too. This also actually brings us back to an old issue, #21, regarding the validation of mod abbreviation inputs.

I think the checks implemented should be as follows:

• tag name: non-empty
• item name: non-empty

Regarding the mod abbreviation, I don't know what an adequate check would be. We actually don't perform any checks on the information passed to Tilesheets either (see also).

Regarding the grid params, I also don't know what an adequate check would be. It's not used much to begin with. Do we need any checks for this?

@retep998

[retep998]

We should definitely verify that the tag name and item name are non-empty and not just whitespace. Grid parameters are optional so we don't need any sort of check on them.

[elifoster]

What about the mod abbreviation?

[retep998]

That too. The mod abbreviation definitely should be required and non-empty and not just whitespace.

[elifoster]

Should we provide any additional checks on it though? I know there are specific requirements the tilesheet program (ftb-rs) has that are not actually enforced in either extension.

[elifoster]

Okay, I looked a bit into stuff. The tag name, item name, and mod abbreviation cannot have any characters that are invalid for a title. They must match $wgLegalTitleChars. See also FTB-Gamepedia/Tilesheets#72.

After this is implemented, someone will need to run a script to check all tile name, tag names, and mod abbreviations that they are valid. For invalid chars, someone will need to manually update the database directly (since invalid characters prevents you from saving any changes after the invalid characters are added).