-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLEX prematurely purges older items from network debugging cache #173
Comments
I propose we give this a try as a replacement: https://github.com/nicklockwood/OSCache Thoughts? |
This is not connected to #91? |
After reviewing the comments it seems to be related, yeah. What happened there? It's 2 years old |
Yeah, I know. 😞 I made a fork and implemented it privately using PINCache for my company internal purposes. The difference is that you cannot opt-out from persistence and PINCache dependency. Unfortunately I didn't have time to implement this and create a PR. I don't think I will have time anywhere soon. 😞 |
Like disk persistence? I'm hoping one of the contributors just gives me the OK to use Nick's cache. Anything is an improvement over the paranoid |
@NSExceptional I've been annoyed by this as well (particularly when backgrounding an app). I'm ok pulling in OSCache if you want to give that a shot. |
Awesome. I'll send a PR when I have time to do it. |
This should be marked as an issue rather than enhancement. Since the user can control the amount of cache space they want to use with a slider (although this is fairly limited given some iOS devices have 4GB of RAM), and they can manually purge the cache, there really is no reason to use NSCache here... it introduces a behaviour that the user doesn't expect. |
FLEX purges older items from the network debugging cache even when the cache is nowhere near full. I would assign this to myself if I could. I would like it to cache them to a temporary file or something, it's super annoying when recent requests are purged for seemingly no reason...
The text was updated successfully, but these errors were encountered: