Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase intentionally hardcoded game size limit / Nintendont shuts down if game larger than 1.36GiB #1183

Open
dreamsyntax opened this issue Feb 24, 2024 · 6 comments · May be fixed by #1213
Open

Increase intentionally hardcoded game size limit / Nintendont shuts down if game larger than 1.36GiB #1183

dreamsyntax opened this issue Feb 24, 2024 · 6 comments · May be fixed by #1213

Comments

@dreamsyntax
Copy link

dreamsyntax commented Feb 24, 2024 •
edited
Loading

Nintendont intentionally shuts down if an ISO is larger than the standard max GameCube ISO size (1.36GiB)

  • GameCube homebrew, such as Swiss can support up to 1.90GiB 3.00GiB (thanks Extrems) ISOs
  • Dolphin can support unlimited size
  • There are various game mods that ship their own Nintendont version to change this limiter to a larger size

Proposal:
Make the mainline maximum size at minimum match with Swiss (3.00GiB), which allows for more compatibility with game mods that add additional content.

I'm intending to open a PR soon to do this, but am opening an issue in case there is a reason these changes have not been accepted in the past.

Update: PR opened:
#1213
@Extrems
Copy link

Extrems commented Mar 6, 2024

The current version of Swiss should work up to 4 GiB-1. If it doesn't then it's a bug.

@dreamsyntax
Copy link
Author

dreamsyntax commented Mar 20, 2024 •
edited
Loading

The current version of Swiss should work up to 4 GiB-1. If it doesn't then it's a bug.

The only thing I can think of is in testing we added an extra singular blob of data and it worked up until the disc total reached 1.9GiB.
Is there a maximum per-file size that breaks Swiss?

@Extrems
Copy link

Extrems commented Mar 30, 2024 •
edited
Loading

You sure your tools aren't broken and aren't using 32-bit signed file offsets internally? I'm struggling to make an image this big.

@dreamsyntax
Copy link
Author

dreamsyntax commented Mar 30, 2024 •
edited
Loading

You sure your tools aren't broken and aren't using 32-bit signed file offsets internally? I'm struggling to make an image this big.

I suppose I can't rule it out?

We just used Dolphin's FST/Extracted Format -> Convert... -> To ISO option in this testing
Sometimes we also rebuild with GCIT to match 1:1 full size, but that would not apply here

@Extrems
Copy link

Extrems commented Mar 30, 2024

I finally had success and got a 3 GiB image working with no issues with the current version of Swiss.

@dreamsyntax
Copy link
Author

Attaching an example of a Nintendont fork with the filesize limit exceeded, categorizing discs separately that meet this case:
master...nfsman34:Nintendont-SonicRiders:master

dreamsyntax added a commit to ShadowTheHedgehogHacking/Nintendont that referenced this issue Jun 30, 2024
@dreamsyntax
Oversized image support
028c06b 
Allows Nintendont to play oversized images, just like Swiss.
Resolves FIX94#1183
Credit to nfsman34
@dreamsyntax dreamsyntax linked a pull request Jun 30, 2024 that will close this issue
Open
dreamsyntax added a commit to ShadowTheHedgehogHacking/Nintendont that referenced this issue Jul 2, 2024
@dreamsyntax
Oversized image support
a3e0b29 
Allows Nintendont to play oversized images, just like Swiss.
Resolves FIX94#1183
Credit to nfsman34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Oversized Image Support ShadowTheHedgehogHacking/Nintendont
2 participants
@Extrems @dreamsyntax