Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit "FOR UPDATE .." On SQLite #577

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Don't emit "FOR UPDATE .." On SQLite #577

merged 1 commit into from
Apr 15, 2024

Commits on Apr 13, 2024

  1. Don't emit "FOR UPDATE .." On SQLite 

    Rather than just ignore it like it does for other things it doesn't
implement, SQLite throws an error with 'FOR UPDATE' on a select
statement.

This just over-rides with an implementation that doesn't emit anything
if there is a '.for'.

The test just checks it doesn't explode with .skip-update, I've
confirmed the SQL generated for both Pg and SQLite visually.
    @jonathanstowe
    jonathanstowe committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    2c9a17b View commit details
    Browse the repository at this point in the history