Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigip_virtual_server - allow to assign irules outside the virtual_server partition #2383

Open
DriesS opened this issue Nov 14, 2023 · 1 comment
Labels
awaiting-user-action issue awaiting user's response and/or requested action enhancement PRs or Issues for basic feature requests for an existing module.

Comments

@DriesS
Copy link

DriesS commented Nov 14, 2023

Is your feature request related to a problem? Please describe.

When specifying irules in the bigip_virtual_server module, the partition assigned to the virtual_server is utilized to locate the corresponding irule.

Describe the solution you'd like

Enable the capability to specify the full path of the irule, similar to how it is done for profiles. If you define the irule name as "/Common/my_irule," the partition specified for the virtual_server should be overridden instead of being prefixed for the irule.

Describe alternatives you've considered

We can include the irule in that particular partition, but since it is a shared irule, this is not an optimal solution.

Additional context

I applied a patch to the local version of the f5-ansible module and successfully resolved the issues. Kindly consider incorporating this into the official release.

https://github.com/F5Networks/f5-ansible/blob/1c9390bb9e1c9cb1f90bb70177ac0fcd28a0cc06/ansible_collections/f5networks/f5_modules/plugins/modules/bigip_virtual_server.py#L2008C16-L2008C16

<             result = fq_name(self.partition, irule)
---
>             tmp = dict()
>             if len(irule.split("/")) > 1:
>                 tmp["partition"] = irule.split("/")[1]
>             else:
>                 tmp["partition"] = self.partition
>             result = fq_name(tmp["partition"], irule)
@DriesS DriesS added enhancement PRs or Issues for basic feature requests for an existing module. untriaged issue that needs an initial response from the developers labels Nov 14, 2023
@pgouband
Copy link
Contributor

Hi @DriesS,

Have you tried using AS3 and ansible declarative collection?

@pgouband pgouband added awaiting-user-action issue awaiting user's response and/or requested action and removed untriaged issue that needs an initial response from the developers labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-action issue awaiting user's response and/or requested action enhancement PRs or Issues for basic feature requests for an existing module.
Projects
None yet
Development

No branches or pull requests

2 participants