Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Tomcat server.xml #47

Open
1 task done
tokland opened this issue Jun 4, 2020 · 3 comments
Open
1 task done

Custom Tomcat server.xml #47

tokland opened this issue Jun 4, 2020 · 3 comments
Labels
general General Maintenance

Comments

@tokland
Copy link
Contributor

tokland commented Jun 4, 2020

  • d2-docker start with customizable server.xml options
@tokland tokland added the general General Maintenance label Jun 4, 2020
@tokland
Copy link
Contributor Author

tokland commented Jul 6, 2020

@ifoche There is also proxyName=..., and some others. I think it would be better to add a single option --tomcat-server-path="my-server.xml" so the user can customize all they need, otherwise we'll end up with lots of options and less control over tomcat.

@tokland tokland changed the title Expose AJP port Custom Tomcat server.xml Jul 6, 2020
@ifoche
Copy link
Member

ifoche commented Jul 6, 2020

@tokland I think you're right, using my-server.xml would provide the user with the capability to change everything, but the user would need to understand all parameters. Given that's for advanced users it might be something acceptable, but then I think we would have to provide them easily with an example to work with, instead of writing it from zero. I don't know how to do that (like generating the default one we're using and maybe in the --help and README explain how to customize?), and I don't know if the user would need to understand the internals of d2-docker for the server.xml to make sense for him/her...what do you think?

@tokland
Copy link
Contributor Author

tokland commented Jul 6, 2020

Yup, it makes to add a section in the readme. The idea to explain is to copy the server.xml from the project as a template and customize, making clear which things cannot be changed (i.e. the 8080 port).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general General Maintenance
Projects
None yet
Development

No branches or pull requests

2 participants