feat: Implement to use a 👍icon next to approved report preview. #53373

Krishna2323 · 2024-12-02T10:59:14Z

Explanation of Change

Fixed Issues

$ #49847
PROPOSAL: #49847 (comment)

Tests

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

Verify that no errors appear in the JS console

Offline tests

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

QA Steps

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

android_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: krishna2323 <[email protected]>

DylanDylann · 2024-12-04T03:32:04Z

@Krishna2323 Please help to confirm

This PR is the same as the previous PR (why do we need to change that?)
After you apply this PR, you can't reproduce the regression bug

Krishna2323 · 2024-12-04T13:22:33Z

This PR is the same as the previous PR (why do we need to change that?)

Its mostly the same with some minor changes.

After you apply this PR, you can't reproduce the regression bug

I tried reproducing the regression bug on a physical device, but I wasn't able to reproduce it. It would be great if you can also test it on a physical device.

WhatsApp.Video.2024-12-02.at.16.25.37.mp4

mjasikowski · 2024-12-04T15:13:22Z

Can't reproduce on this branch with Pixel 4a:

Screen.Recording.2024-12-04.at.16.11.28.mov

DylanDylann · 2024-12-04T15:52:52Z

Its mostly the same with some minor changes.

@Krishna2323 Could you detail changes?

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-05T06:58:37Z

src/components/ReportActionItem/ReportPreview.tsx

+    const thumbsUpScale = useSharedValue(isApproved ? 1 : 0);
+    const thumbsUpStyle = useAnimatedStyle(() => ({
+        ...styles.defaultCheckmarkWrapper,
+        transform: [{scale: thumbsUpScale.get()}],


@DylanDylann, previously we were using .value property to get the value, now it is updated to .get() method.

Krishna2323 · 2024-12-05T07:01:25Z

src/components/ReportActionItem/ReportPreview.tsx

+            return;
+        }
+
+        thumbsUpScale.set(withSpring(1, {duration: CONST.ANIMATION_PAID_DURATION}));


@DylanDylann, in the previous PR the duration was set to 200, I updated it to ANIMATION_PAID_DURATION constant which is also 200. its better to use the constant everywhere for consistency.

these are the only changes which are different from the previous PR.

melvin-bot · 2024-12-05T07:01:54Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-12-05T08:07:52Z

@Krishna2323 Could you also explain why the regression bug is resolved on this PR?

Krishna2323 · 2024-12-05T14:22:38Z

Could you also explain why the regression bug is resolved on this PR?

I'm not sure why it was happening in the previous PR, as you can see that there is no major differences between this and the previous PR.

DylanDylann · 2024-12-06T07:40:00Z

Hmmm, So weird, I also don't understand why this bug happen in the previous PR

DylanDylann · 2024-12-06T08:30:16Z

src/components/ReportActionItem/ReportPreview.tsx

@@ -149,14 +155,20 @@ function ReportPreview({
    const previewMessageStyle = useAnimatedStyle(() => ({
        opacity: previewMessageOpacity.get(),
    }));
-    const checkMarkScale = useSharedValue(iouSettled ? 1 : 0);
+    const checkMarkScale = useSharedValue(iouSettled ? 1 : 0.25);


@Krishna2323 Is this changed?

hmm, sorry, the values are swapped between checkMarkScale & thumbsUpScale. Now updated.

Actually, we need 0 as the initial value for thumbsUpScale also, because on mWeb, it can be visible at .25 scale before it is updated to 1 with animation.

DylanDylann · 2024-12-06T08:30:22Z

src/components/ReportActionItem/ReportPreview.tsx

+    const checkMarkScale = useSharedValue(iouSettled ? 1 : 0.25);
+
+    const isApproved = ReportUtils.isReportApproved(iouReport, action);
+    const thumbsUpScale = useSharedValue(isApproved ? 1 : 0);


@Krishna2323 Is this changed?

hmm, sorry, the values are swapped between checkMarkScale & thumbsUpScale. Now updated.

DylanDylann · 2024-12-06T08:34:16Z

@Krishna2323 Please test again this PR and upload videos again.

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-08T02:59:29Z

src/components/ReportActionItem/ReportPreview.tsx

+            return;
+        }
+
+        thumbsUpScale.set(isApprovedAnimationRunning ? withDelay(CONST.ANIMATION_THUMBSUP_DELAY, withSpring(1, {duration: CONST.ANIMATION_THUMBSUP_DURATION})) : 1);


Updated this to add some delay because the animation can seem frozen if the button and icon animations run together at the same time. Same approach is also used for checkmark icon animation.

@Krishna2323 It caused the regression on the previous PR or did you add it for safer?

It caused the regression

No, its just for fixing animation lag.

Krishna2323 · 2024-12-08T03:00:31Z

@DylanDylann, recordings updated.

DylanDylann · 2024-12-09T07:23:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-09.at.14.22.35.mov

Android: mWeb Chrome

Screen.Recording.2024-12-09.at.14.17.00.mov

iOS: Native

Screen.Recording.2024-12-09.at.14.18.39.mov

iOS: mWeb Safari

Screen.Recording.2024-12-09.at.14.15.04.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-09.at.14.01.18.mov

MacOS: Desktop

Screen.Recording.2024-12-09.at.14.12.56.mov

mjasikowski · 2024-12-09T08:38:55Z

Just FYI the Reanimated library version has changed since the previous PR, so that may have contributed to the fix as well.

Krishna2323 · 2024-12-09T22:29:29Z

Just FYI the Reanimated library version has changed since the previous PR, so that may have contributed to the fix as well.

I also think the same, this PR has no additional changes comparing to the previous PR which could have been the reason for the regression.

Krishna2323 added 4 commits December 2, 2024 16:26

feat: Implement to use a 👍icon next to approved report preview.

38fe4e0

Signed-off-by: krishna2323 <[email protected]>

minor update.

ea3767e

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/fix2_49847

c6b6417

fix merge conflicts.

c1e009c

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 mentioned this pull request Dec 3, 2024

Feat: Implement to use a 👍icon next to approved report preview #50387

Merged

50 tasks

Merge branch 'main' into krishna2323/issue/fix2_49847

25b499c

Krishna2323 added 3 commits December 5, 2024 10:24

Merge branch 'Expensify:main' into krishna2323/issue/fix2_49847

7d1f410

minor update.

3e474d6

Signed-off-by: krishna2323 <[email protected]>

change scale value.

8bbd98e

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 commented Dec 5, 2024

View reviewed changes

Krishna2323 marked this pull request as ready for review December 5, 2024 07:01

Krishna2323 requested a review from a team as a code owner December 5, 2024 07:01

melvin-bot bot requested review from DylanDylann and removed request for a team December 5, 2024 07:01

DylanDylann reviewed Dec 6, 2024

View reviewed changes

Krishna2323 added 5 commits December 8, 2024 07:22

minor update.

827b107

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/fix2_49847

af9117c

update thumbsUpScale value.

b9bcefd

Signed-off-by: krishna2323 <[email protected]>

update animation time of thumbs up icon.

2eff212

Signed-off-by: krishna2323 <[email protected]>

add delay to thumbs-up icon.

24818db

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 commented Dec 8, 2024

View reviewed changes

DylanDylann approved these changes Dec 9, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr December 9, 2024 07:24

mjasikowski assigned Krishna2323 Dec 9, 2024

Merge branch 'Expensify:main' into krishna2323/issue/fix2_49847

ebde15d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement to use a 👍icon next to approved report preview. #53373

feat: Implement to use a 👍icon next to approved report preview. #53373

Krishna2323 commented Dec 2, 2024 •

edited

Loading

DylanDylann commented Dec 4, 2024 •

edited

Loading

Krishna2323 commented Dec 4, 2024

mjasikowski commented Dec 4, 2024

DylanDylann commented Dec 4, 2024

Krishna2323 Dec 5, 2024

Krishna2323 Dec 5, 2024

Krishna2323 Dec 5, 2024

melvin-bot bot commented Dec 5, 2024

DylanDylann commented Dec 5, 2024

Krishna2323 commented Dec 5, 2024

DylanDylann commented Dec 6, 2024

DylanDylann Dec 6, 2024

Krishna2323 Dec 8, 2024

Krishna2323 Dec 8, 2024

DylanDylann Dec 6, 2024

Krishna2323 Dec 8, 2024

DylanDylann commented Dec 6, 2024

Krishna2323 Dec 8, 2024 •

edited

Loading

DylanDylann Dec 9, 2024 •

edited

Loading

Krishna2323 Dec 9, 2024

Krishna2323 commented Dec 8, 2024

DylanDylann commented Dec 9, 2024

mjasikowski commented Dec 9, 2024

Krishna2323 commented Dec 9, 2024

feat: Implement to use a 👍icon next to approved report preview. #53373

Are you sure you want to change the base?

feat: Implement to use a 👍icon next to approved report preview. #53373

Conversation

Krishna2323 commented Dec 2, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

DylanDylann commented Dec 4, 2024 • edited Loading

Krishna2323 commented Dec 4, 2024

mjasikowski commented Dec 4, 2024

DylanDylann commented Dec 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 5, 2024

DylanDylann commented Dec 5, 2024

Krishna2323 commented Dec 5, 2024

DylanDylann commented Dec 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented Dec 6, 2024

Krishna2323 Dec 8, 2024 • edited Loading

Choose a reason for hiding this comment

DylanDylann Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krishna2323 commented Dec 8, 2024

DylanDylann commented Dec 9, 2024

Reviewer Checklist

Screenshots/Videos

mjasikowski commented Dec 9, 2024

Krishna2323 commented Dec 9, 2024

Krishna2323 commented Dec 2, 2024 •

edited

Loading

DylanDylann commented Dec 4, 2024 •

edited

Loading

Krishna2323 Dec 8, 2024 •

edited

Loading

DylanDylann Dec 9, 2024 •

edited

Loading