-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal QA]: Fix: Logged-In Agents Can Appear to Delete Workspaces in NewDot Without Actual Deletion or Error Message #53333
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
546e8ab
add blocking modal for support agents
twilight2294 0987959
Fix prettier and rename component
twilight2294 cd8f777
add dependency
twilight2294 88337ae
Update src/languages/es.ts
twilight2294 013f5ab
update modal name
twilight2294 05b01c8
update component name
twilight2294 1b5ae43
fix import
twilight2294 c2ec2f6
Rename SupportalActionModal.tsx to SupportalActionRestrictedModal.tsx
twilight2294 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import React from 'react'; | ||
import useLocalize from '@hooks/useLocalize'; | ||
import ConfirmModal from './ConfirmModal'; | ||
|
||
type SuppportalActionNotAllowedModalProps = { | ||
isSupportalActionRestrictedModalOpen: boolean; | ||
hideSupportalModal: () => void; | ||
}; | ||
|
||
function SuppportalActionNotAllowedModal({isSupportalActionRestrictedModalOpen, hideSupportalModal}: SuppportalActionNotAllowedModalProps) { | ||
Check failure on line 10 in src/components/SupportalActionNotAllowedModal.tsx GitHub Actions / Changed files ESLint check
|
||
const {translate} = useLocalize(); | ||
return ( | ||
<ConfirmModal | ||
title={translate('supportalNoAccess.title')} | ||
isVisible={isSupportalActionRestrictedModalOpen} | ||
onConfirm={hideSupportalModal} | ||
prompt={translate('supportalNoAccess.description')} | ||
confirmText={translate('common.buttonConfirm')} | ||
shouldShowCancelButton={false} | ||
/> | ||
); | ||
} | ||
|
||
SuppportalActionNotAllowedModal.displayName = 'SuppportalActionNotAllowedModal'; | ||
|
||
export default SuppportalActionNotAllowedModal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allgandalf can you please confirm these translation ? I am still to be added on slack, the above translation for title is already present in the codebase picked it up from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked on slack here