Fix 49974 attachment infinite loading #50511

Kalydosos · 2024-10-09T16:14:05Z

Note : this PR is completed by PR #52195 to avoid force pushing the branch. This PR keeps the timeline and history for all discussions

Details

Fixed Issues

$ #49974
PROPOSAL: #49974 (comment)

Tests

Launch the app.
Open a chat
Paste the text
Send the message
Click on the image
Verify that an icon and the text "No Attachment Found" are displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.2.mp4

Android: mWeb Chrome

android_mweb.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

macos_web_safari.mp4

MacOS: Desktop

github-actions · 2024-10-09T16:14:19Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

melvin-bot · 2024-10-09T16:14:36Z

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kalydosos · 2024-10-15T19:38:35Z

@hoangzinh Hi, i'm pinging you about the translation process. We need to translate the wording "Attachment not found" in spanish (alone ?). Thx

hoangzinh · 2024-10-16T09:28:39Z

@hoangzinh Hi, i'm pinging you about the translation process. We need to translate the wording "Attachment not found" in spanish (alone ?). Thx

Sure, asked for confirmation here https://expensify.slack.com/archives/C01GTK53T8Q/p1729070840273779

src/components/Attachments/AttachmentView/index.tsx

hoangzinh · 2024-10-17T09:38:42Z

@Kalydosos I got translation confirmation. They said that we should use "Archivo adjunto no encontrado" instead of "Adjunto no encontrado"

hoangzinh · 2024-10-17T09:38:58Z

src/languages/es.ts

@@ -1959,6 +1959,7 @@ const translations = {
            afterLinkText: 'para verlo.',
            formLabel: 'Ver PDF',
        },
+        attachmentNotFound: 'Adjunto no encontrado'


Suggested change

attachmentNotFound: 'Adjunto no encontrado'

attachmentNotFound: 'Archivo adjunto no encontrado'

ok, got it. Thx a lot

Kalydosos · 2024-10-17T16:35:39Z

@Expensify/design will be needed for review

Kalydosos · 2024-10-17T17:22:39Z

I have read the CLA Document and I hereby sign the CLA

Kalydosos · 2024-10-18T10:57:18Z

recheck

Kalydosos · 2024-10-18T11:00:52Z

I have read the CLA Document and I hereby sign the CLA

hoangzinh · 2024-10-18T11:58:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-05.at.06.42.10.android.mov

Android: mWeb Chrome

Screen.Recording.2024-11-05.at.06.39.31.android.chrome.mov

iOS: Native

Screen.Recording.2024-11-05.at.06.47.48.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-11-05.at.06.49.36.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-05.at.06.35.53.web.mov

MacOS: Desktop

Screen.Recording.2024-11-05.at.06.40.22.desktop.mov

shawnborton · 2024-10-18T14:13:52Z

For this screenshot here:

I think the icon above the headline text should use our icon color, right @Expensify/design? It looks a little light, so just want to double check. Thanks!

shawnborton · 2024-10-18T14:14:11Z

src/components/Attachments/AttachmentView/index.tsx

+                        src={fallbackSource}
+                        width={variables.iconSizeSuperLarge}
+                        height={variables.iconSizeSuperLarge}
+                        fill={theme.border}


Consider making this theme.icons instead

Ok, thx for the feedback

I tried theme.icon but it"s still light as you can see in the pic below

but a theme that seems to match better the "Attachment not found" text in both light and dark modes is theme.iconHovered as you can see in the pic below

What do you think ? also @dannymcclain

The first pic (theme.icon) looks correct!

Ok @dannymcclain thx for the feedback 👍 , @shawnborton i will update the code if it's ok with you

Yup, Danny is correct!

@shawnborton yes, i have updated the code already. thx for the feedback 👍

dannymcclain · 2024-10-18T14:41:03Z

I think the icon above the headline text should use our icon color, right @Expensify/design?

Yes that's correct!

hoangzinh · 2024-10-21T10:09:46Z

@Kalydosos can you add test steps for "Offline tests" and "QA tests"? Thank you

hoangzinh · 2024-10-21T11:01:25Z

Bug 1: App shows "Attachment not found" error instead of an "Offline" message when view images in Offline mode.

Screen.Recording.2024-10-21.at.17.57.19.mov

Click here to view before changes

Screen.Recording.2024-10-21.at.17.58.14.mov

hoangzinh · 2024-11-04T16:20:15Z

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx

@@ -67,7 +67,7 @@ function ImageRenderer({tnode}: ImageRendererProps) {

    const fileType = FileUtils.getFileType(attachmentSourceAttribute);
    const fallbackIcon = fileType === CONST.ATTACHMENT_FILE_TYPE.FILE ? Expensicons.Document : Expensicons.GalleryNotFound;
-    const [hasLoadFailed, setHasLoadFailed] = useState(true);
+    const [, setHasLoadFailed] = useState(true);


If hasLoadFailed won't be used, we can completely remove setHasLoadFailed too.

@hoangzinh no we cant, it's used in the code, here per example

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx

Line 83 in f2e295f

onLoadFailure={() => setHasLoadFailed(true)}

We just dont access the variable hasLoadFailed but it used by useState

Just remove them @Kalydosos

@hoangzinh ok i checked, it's done, thx 👍

hoangzinh · 2024-11-04T23:30:52Z

src/components/ImageView/index.tsx

+    // isLocalToUserDeviceFile means the file is located on the user device,
+    // not loaded on the server yet (the user is offline when loading this file in fact)
+    let isLocalToUserDeviceFile = FileUtils.isLocalFile(url);
+    if (isLocalToUserDeviceFile && typeof url === 'string' && url.startsWith('/chat-attachments')){


Suggested change

if (isLocalToUserDeviceFile && typeof url === 'string' && url.startsWith('/chat-attachments')){

if (isLocalToUserDeviceFile && typeof url === 'string' && url.startsWith('/chat-attachments')) {

Need a space here. You can run "npm run prettier" to auto fix those linter

Done and commited, thx 👍

hoangzinh · 2024-11-05T00:09:54Z

If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack

Found a unrelated console error during testing with video, reported here https://expensify.slack.com/archives/C049HHMV9SM/p1730765319227739

hoangzinh · 2024-11-06T08:02:17Z

@Kalydosos we are nearly done here. Just in case you missed this comment #50511 (comment)

hoangzinh

LGTM. @Kalydosos congrats on your first PR

MariaHCD

LGTM! We can get this merged once we have a final review from design

MariaHCD · 2024-11-06T12:42:02Z

Ooops, @Kalydosos two issues:

There is an unverified commit fff2058b246e1f45ae4a0f952a48a9a35175a4e2:

There is an ESLint error:

Kalydosos · 2024-11-06T13:46:30Z

@MariaHCD issue 2 is fixed, i have commited the change. I'm working on fixing issue 1. Thx for the feedback, 👍

dannymcclain · 2024-11-06T13:55:30Z

Not sure exactly where the latest screenshots/videos are—but I think the styles are all looking good to me. If these two videos are the latest, I think it's looking good. 👍

Kalydosos · 2024-11-06T15:00:29Z

@dannymcclain yes these videos are the lastest, thx for the feedback 👍

Kalydosos · 2024-11-06T15:43:12Z

@MariaHCD issue 2 is fixed, i have commited the change. I'm working on fixing issue 1. Thx for the feedback, 👍

@MariaHCD i will resign all the commits, which will sign the first one in question but the commits ids will change. I hope this will not break any of the automation of the process as i will have to force push the branch. Any thoughts on that ?

Kalydosos · 2024-11-06T16:24:29Z

@MariaHCD issue 2 is fixed, i have commited the change. I'm working on fixing issue 1. Thx for the feedback, 👍

@MariaHCD i will resign all the commits, which will sign the first one in question but the commits ids will change. I hope this will not break any of the automation of the process as i will have to force push the branch. Any thoughts on that ?

@hoangzinh any advice also ? I'm about the rebase and force push the branch

hoangzinh · 2024-11-06T19:17:28Z

I'm unsure too. @MariaHCD can we just ignore that unsigned commit or we have to fix it

hoangzinh · 2024-11-07T01:55:38Z

It seems PR can't be allowed to merge if there is an unverified commit. @MariaHCD what do you think if we:

Rebase and force push this PR (Although it violates contributing guidelines but it keeps our discussions in this PR)
Or close this PR and open another PR (mention to current PR if anyone wants to back read discussions)

MariaHCD · 2024-11-07T09:56:20Z

It seems PR can't be allowed to merge if there is an unverified commit

Yes, we can't merge a PR that has an unverified commit.

Or close this PR and open another PR (mention to current PR if anyone wants to back read discussions)

This seems like the best option because force pushing might change the review history. Let's go with this option 👍🏼

Kalydosos · 2024-11-07T11:59:22Z

@MariaHCD @hoangzinh ok, i will set it up right away. thx for your advices 👍

hoangzinh · 2024-11-08T01:37:39Z

@Kalydosos we can close this PR

Kalydosos · 2024-11-08T17:20:53Z

@Kalydosos we can close this PR

@hoangzinh it's done, thx 👍

Kalydosos · 2024-11-13T17:43:05Z

LGTM. @Kalydosos congrats on your first PR

thank you @hoangzinh for your help

Kalydosos added 2 commits October 9, 2024 15:58

fix-49974 infinite loading for invalid attachment source

fff2058

fix-49974 infinite loading for invalid attachment source

0d498e2

Kalydosos requested a review from a team as a code owner October 9, 2024 16:14

melvin-bot bot requested a review from chiragsalian October 9, 2024 16:14

melvin-bot bot removed the request for review from a team October 9, 2024 16:14

Kalydosos marked this pull request as draft October 9, 2024 16:15

Kalydosos mentioned this pull request Oct 9, 2024

[HOLD for payment 2024-11-22] [$250] Chat - Attachment - Opening specific image page keeps loading infinitely #49974

Closed

6 tasks

update with design

1113ed6

hoangzinh reviewed Oct 16, 2024

View reviewed changes

src/components/Attachments/AttachmentView/index.tsx Show resolved Hide resolved

hoangzinh reviewed Oct 17, 2024

View reviewed changes

update from translation

59ca13c

Kalydosos marked this pull request as ready for review October 18, 2024 10:57

Kalydosos requested a review from a team as a code owner October 18, 2024 10:57

shawnborton reviewed Oct 18, 2024

View reviewed changes

huult mentioned this pull request Oct 19, 2024

fix gray placeholder shown for markdown images with invalid URLs #50918

Merged

50 tasks

Update index.tsx with Design to match current icon theme

6090c91

hoangzinh reviewed Nov 4, 2024

View reviewed changes

fix for prettier tool

a58ee30

clean up useState

568406e

hoangzinh approved these changes Nov 6, 2024

View reviewed changes

MariaHCD approved these changes Nov 6, 2024

View reviewed changes

MariaHCD requested review from dannymcclain, MariaHCD and shawnborton November 6, 2024 12:36

MariaHCD previously approved these changes Nov 6, 2024

View reviewed changes

fix eslint

8ccbaf9

Kalydosos dismissed MariaHCD’s stale review via 8ccbaf9 November 6, 2024 13:41

Kalydosos mentioned this pull request Nov 7, 2024

fix-49974-attachment-infinite-loading #52195

Merged

50 tasks

Kalydosos closed this Nov 8, 2024

Kalydosos deleted the fix-49974-attachment-infinite-loading branch November 8, 2024 17:21

	attachmentNotFound: 'Adjunto no encontrado'
	attachmentNotFound: 'Archivo adjunto no encontrado'

	if (isLocalToUserDeviceFile && typeof url === 'string' && url.startsWith('/chat-attachments')){
	if (isLocalToUserDeviceFile && typeof url === 'string' && url.startsWith('/chat-attachments')) {

Fix 49974 attachment infinite loading #50511

Fix 49974 attachment infinite loading #50511

Conversation

Kalydosos commented Oct 9, 2024 • edited Loading

Note : this PR is completed by PR #52195 to avoid force pushing the branch. This PR keeps the timeline and history for all discussions

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Oct 9, 2024 • edited Loading

melvin-bot bot commented Oct 9, 2024

Kalydosos commented Oct 15, 2024

hoangzinh commented Oct 16, 2024

hoangzinh commented Oct 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalydosos commented Oct 17, 2024

Kalydosos commented Oct 17, 2024

Kalydosos commented Oct 18, 2024

Kalydosos commented Oct 18, 2024

hoangzinh commented Oct 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

shawnborton commented Oct 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalydosos Oct 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dannymcclain commented Oct 18, 2024

hoangzinh commented Oct 21, 2024

hoangzinh commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalydosos Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

hoangzinh commented Nov 5, 2024

hoangzinh commented Nov 6, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

MariaHCD left a comment

Choose a reason for hiding this comment

MariaHCD commented Nov 6, 2024

Kalydosos commented Nov 6, 2024

dannymcclain commented Nov 6, 2024

Kalydosos commented Nov 6, 2024

Kalydosos commented Nov 6, 2024 • edited Loading

Kalydosos commented Nov 6, 2024

hoangzinh commented Nov 6, 2024

hoangzinh commented Nov 7, 2024

MariaHCD commented Nov 7, 2024

Kalydosos commented Nov 7, 2024

hoangzinh commented Nov 8, 2024

Kalydosos commented Nov 8, 2024

Kalydosos commented Nov 13, 2024

Kalydosos commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

hoangzinh commented Oct 18, 2024 •

edited

Loading

Kalydosos Oct 19, 2024 •

edited

Loading

Kalydosos Nov 5, 2024 •

edited

Loading

Kalydosos commented Nov 6, 2024 •

edited

Loading