Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-11] [HOLD for payment 2024-12-09] Android - Navigation bar is white, FAB and more options menu overlap with navigation bar #53337

Closed
2 of 8 tasks
IuliiaHerets opened this issue Nov 30, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Device navigation is buttons and not gestures.
  1. Launch ND or hybrid app.
  2. Open FAB.
  3. Go to Search.
  4. Select any expense by long pressing on the expense and choose Select.
  5. Tap on the dropdown.

Expected Result:

Production behavior:

  • Navigation bar is green (follows app color)
  • FAB and more options menu do not overlap with navigation bar

Actual Result:

  • Navigation bar is white.
  • FAB and more options menu overlap with navigation bar

3-dot menu, search modal, emoji picker (when opened from long press menu, then tap add emoji icon) from different app area also overlaps with the navigation bar.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6680691_1732981970564.Screen_Recording_20241130_235206.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 30, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 30, 2024

💬 A slack conversation has been started in #expensify-open-source

@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2024

I think we might be able to demote this one as the overlap should be fixed in this pr #53250 which is in main and this issue was in previous versions but we did not deploy to production hybrid.

The colour of the navigation bar also does not feel like a blocking aspect, with the edge to edge it should take the bg of the screen

cc @kirillzyusko @chrispader @hannojg

@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2024

The navigation bar is apparently reproducible in standalone android app that was not the case in the previous version i believe. Can you repro in emulator locally? @kirillzyusko

@kirillzyusko
Copy link
Contributor

@mountiny let me try 👀 Can you assign this ticket on me?

@mountiny mountiny assigned kirillzyusko and mountiny and unassigned AndrewGable Dec 2, 2024
@shubham1206agra
Copy link
Contributor

@kirillzyusko Ping me here when you create a PR for this. I can do the quick review if required.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 2, 2024
@kirillzyusko
Copy link
Contributor

@shubham1206agra PR is ready for review: #53376

@shubham1206agra
Copy link
Contributor

@mountiny Assign me here for review

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Dec 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Dec 2, 2024

PR being CPed, QA will retest this once in staging

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 2, 2024
@melvin-bot melvin-bot bot changed the title Android - Navigation bar is white, FAB and more options menu overlap with navigation bar [HOLD for payment 2024-12-09] Android - Navigation bar is white, FAB and more options menu overlap with navigation bar Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-09. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 2, 2024

@shubham1206agra @slafortune @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-09] Android - Navigation bar is white, FAB and more options menu overlap with navigation bar [HOLD for payment 2024-12-11] [HOLD for payment 2024-12-09] Android - Navigation bar is white, FAB and more options menu overlap with navigation bar Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-11. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 4, 2024

@shubham1206agra @slafortune @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 9, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Payment Summary

Upwork Job

BugZero Checklist (@slafortune)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2024
@slafortune
Copy link
Contributor

@shubham1206agra - offer sent here

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2024
@slafortune
Copy link
Contributor

@kirillzyusko Role Contributor does not require payment
@shubham1206agra Role C+ Paid $250 via Upworks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants