-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-11] [HOLD for payment 2024-12-09] Android - Navigation bar is white, FAB and more options menu overlap with navigation bar #53337
Comments
Triggered auto assignment to @AndrewGable ( |
Triggered auto assignment to @slafortune ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
💬 A slack conversation has been started in #expensify-open-source |
I think we might be able to demote this one as the overlap should be fixed in this pr #53250 which is in main and this issue was in previous versions but we did not deploy to production hybrid. The colour of the navigation bar also does not feel like a blocking aspect, with the edge to edge it should take the bg of the screen |
The navigation bar is apparently reproducible in standalone android app that was not the case in the previous version i believe. Can you repro in emulator locally? @kirillzyusko |
@mountiny let me try 👀 Can you assign this ticket on me? |
@kirillzyusko Ping me here when you create a PR for this. I can do the quick review if required. |
@shubham1206agra PR is ready for review: #53376 |
@mountiny Assign me here for review |
PR being CPed, QA will retest this once in staging |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-09. 🎊 For reference, here are some details about the assignees on this issue:
|
@shubham1206agra @slafortune @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-11. 🎊 For reference, here are some details about the assignees on this issue:
|
@shubham1206agra @slafortune @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Payment Summary
BugZero Checklist (@slafortune)
|
@shubham1206agra - offer sent here |
@kirillzyusko Role Contributor does not require payment |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
Production behavior:
Actual Result:
3-dot menu, search modal, emoji picker (when opened from long press menu, then tap add emoji icon) from different app area also overlaps with the navigation bar.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6680691_1732981970564.Screen_Recording_20241130_235206.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @slafortuneThe text was updated successfully, but these errors were encountered: