[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Held expense - Pay button disappears after holding one of the expenses

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit two expenses to user B.
3. [User B] Go to chat with user A.
4. [User B] Go to expense report.
5. [User B] Hold one of the expenses.

Expected Result:

Pay button should not disappear after holding one of the expenses.

Actual Result:

Pay button disappears after holding one of the expenses.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6677357_1732651388426.20241127_040104.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath / @RachCHopkins

Issue Owner

Current Issue Owner: @puneetlath / @RachCHopkins

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[RachCHopkins]

@Beamanator also just picked up on this while testing a different issue. I have just been testing and can replicate.

[mountiny]

@hoangzinh @abzokhattab Maybe related to #51133 can you check please?

[mountiny]

Discussing in slack, hold is technically a violation too, but we should not hide the buttons in this case, so lets exclude it

[abzokhattab]

based on our discussion on Slack lets exclude violations that have hold names when hiding the approve/pay buttons

[abzokhattab]

Raised the PR here

[mountiny]

We reverted the original PR and the PCed PR because the expected results been incorrect #50479 lets handle that back in that issue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: Avoid hiding pay/approve buttons in case of held violations #53176

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @abzokhattab requires payment (Needs manual offer from BZ)

[melvin-bot]

@puneetlath / @mountiny @puneetlath / @RachCHopkins @abzokhattab The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: Avoid hiding pay/approve buttons in case of held violations #53176

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

• @abzokhattab requires payment (Needs manual offer from BZ)

[melvin-bot]

@puneetlath / @mountiny @puneetlath / @RachCHopkins @abzokhattab The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]