[$250] Show expense in RHP when new expense is added from Search page

[dubielzyk-expensify]

Problem

When a user creates an expense from the Search page today and have filters set to Chat or Invoices, the user won't know that the expense got successfully created. Here's a video of the issue:

CleanShot.2024-11-14.at.14.13.26.mp4

Solution

When an expense is created on the Search page, show the created expense in the RHP to ensure the user is aware that their expense was created successfully.

cc @Expensify/design

Issue Owner

Current Issue Owner: @WojtekBoman

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857449060653341195
• Upwork Job ID: 1857449060653341195
• Last Price Increase: 2024-11-15

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-11-15 09:05:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show expense in RHP when new expense is added from Search page

What is the root cause of that problem?

A feature request.

What changes do you think we should make in order to solve the problem?

We should open the Report in RHP after completing the IOU action.

For example in requestMoney action, instead of directly dismissModal:

App/src/libs/actions/IOU.ts

Line 3668 in a6f1348

Navigation.dismissModal(isSearchTopmostCentralPane() ? undefined : activeReportID);

to:

if (isSearchTopmostCentralPane()) {
        Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: iouReport.reportID, reportActionID: createdIOUReportActionID}));
        return;
    }
    Navigation.dismissModal(activeReportID);

We can explicitly check if the current search filter is other than Expenses before navigating. Because in Expenses filter, we will briefly highlight the created expense in the expenses list.

We need to apply this change to other IOU actions: trackExpense, sendInvoice, createDistanceRequest, splitBill,...

[WojtekBoman]

Hey! I am Wojtek from Software Mansion, an expert agency. Currently we are working together with @adamgrzybowski on Refactor RHP flow to contain navigation within itself. I can take a look at it as it should be covered by the solution we are implementing.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857449060653341195

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

@eVoloshchak, @luacmartins, @WojtekBoman, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[WojtekBoman]

I'm still working on that 🫡

[melvin-bot]

@eVoloshchak, @luacmartins, @WojtekBoman, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@eVoloshchak, @luacmartins, @WojtekBoman, @adelekennedy 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[adamgrzybowski]

Still in progress

[melvin-bot]

@eVoloshchak, @luacmartins, @WojtekBoman, @adelekennedy 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@eVoloshchak @luacmartins @WojtekBoman @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@eVoloshchak, @luacmartins, @WojtekBoman, @adelekennedy 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @eVoloshchak, @luacmartins, @WojtekBoman, @adelekennedy eroding to Weekly issue.

[WojtekBoman]

It's still in progress as we had to wait for merging the native stack PR, currently we're adjusting this PR to changes introduced by native stacks. When we finish it, I'll raise a PR for this issue