Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - selfDM is not shown in search #51471

Closed
4 of 8 tasks
lanitochka17 opened this issue Oct 25, 2024 · 13 comments
Closed
4 of 8 tasks

Search - selfDM is not shown in search #51471

lanitochka17 opened this issue Oct 25, 2024 · 13 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5131233
Issue reported by: Applause - Internal Team

Action Performed:

  1. Login with an applause email
  2. Search for selfDM

Expected Result:

SelfDM is shown in the search result

Actual Result:

SelfDM is not shown in the search result for a private domain.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6645542_1729862262578.2024-10-25_16.17.14.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 25, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 25, 2024

💬 A slack conversation has been started in #expensify-open-source

@luacmartins
Copy link
Contributor

Left a comment on this PR that's potentially related

@hannojg
Copy link
Contributor

hannojg commented Oct 28, 2024

hm, will try to reproduce differently, but i can't seem to reproduce on dev:

Screenshot 2024-10-28 at 09 35 46

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@hannojg
Copy link
Contributor

hannojg commented Oct 28, 2024

hm no, i just can't reproduce it, neither on staging. I don't think this related to the mentioned PR

@Beamanator
Copy link
Contributor

Any ideas here about this being front of backend-related? 🤔

@Beamanator
Copy link
Contributor

I could find the selfDM in search if I type (you) so I wonder if we should call this NAB?

@hannojg
Copy link
Contributor

hannojg commented Oct 28, 2024

@Beamanator but you weren't able to find it by searching for your mail address?

@luacmartins
Copy link
Contributor

I think this is a sorting priority issue. Try creating many chat reports (threads) that match the search term. In the example I posted in Slack, all the results seem to match the search input, but all the threads are prioritized above the "main" self-dm report

@Beamanator
Copy link
Contributor

Ooh now I can see it easily - I wonder if this was fixed by the revert that @luacmartins recommended here?

@Beamanator
Copy link
Contributor

Beamanator commented Oct 29, 2024

as mentioned in slack here, this was fixed! I won't close it in case @stitesExpensify wants to try to get to the bottom of which PR revert fixed this

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Oct 29, 2024
@stitesExpensify
Copy link
Contributor

I do not have time to dig on that with travel right now. I'm going to close since it is fixed

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants