Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v2.4] Use text style for router input #50814

Closed
luacmartins opened this issue Oct 15, 2024 · 8 comments
Closed

[Search v2.4] Use text style for router input #50814

luacmartins opened this issue Oct 15, 2024 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 15, 2024

Problem

Coming from here, we should use text color for the search router input text.

Solution

Update the text color

Issue OwnerCurrent Issue Owner: @greg-schroeder
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 15, 2024
@luacmartins luacmartins self-assigned this Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 15, 2024
@greg-schroeder
Copy link
Contributor

there are no contributors here, so this can be closed as soon as it's merged and deployed to prod

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.4] Use text style for router input [HOLD for payment 2024-10-25] [Search v2.4] Use text style for router input Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-25. 🎊

Copy link

melvin-bot bot commented Oct 18, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: N/A new feature under development
  • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A new feature
  • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
  • [@luacmartins] Determine if we should create a regression test for this bug. No tests needed
  • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
  • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dylanexpensify dylanexpensify moved this to Hold for Payment in [#whatsnext] #expense Oct 18, 2024
@greg-schroeder greg-schroeder changed the title [HOLD for payment 2024-10-25] [Search v2.4] Use text style for router input [Search v2.4] Use text style for router input Oct 23, 2024
@greg-schroeder
Copy link
Contributor

Closing per this as this is finished up!

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Oct 23, 2024
@tgolen
Copy link
Contributor

tgolen commented Oct 23, 2024

Reopening so that @luacmartins and @greg-schroeder can finish the regression checklist

@tgolen tgolen reopened this Oct 23, 2024
@luacmartins
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants