[HOLD for payment 2024-10-25] [$250] Onboarding - New user lands on workspace chat when 'Manage my team's expenses' selected in modal

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.47-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5070660
Issue reported by: Applause - Internal Team

Action Performed:

1. Open New Expensify app
2. Log in with new gmail user
3. Select 'Manage my team's expenses' in onboarding modal
4. Enter workspace name, user name and submit modal

Expected Result:

Either Concierge chat or LHN should be displayed

Actual Result:

Workspace chat is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6630791_1728569605765.OHBK2619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844427822228964480
• Upwork Job ID: 1844427822228964480
• Last Price Increase: 2024-10-10

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[allgandalf]

Our PR touched the onboarding flow recently, looking into it.. will update in sometime! @MarioExpensify

[allgandalf]

@twilight294 , please check on your end too, if this is a regression from our PR, you need to fix it too

[allgandalf]

@MarioExpensify I reverted our PR and tested it here, but the bug is still reproducible, so not related to our PR, but i would love to help you on this one, I will stay subscribed to this thread:

Screen.Recording.2024-10-10.at.8.08.46.PM.mov

[MarioExpensify]

Trying to track down which PR caused the issue right now

[allgandalf]

Cool, our washttps://github.com/Expensify/App/pull/50359, not linking cause it makes melvin to notify 😅

[allgandalf]

Crap, it did anyway 💢

[MarioExpensify]

Still haven't been able to come up with a fix for this one, @allgandalf feel free to hop in

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844427822228964480

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-10 17:56:10 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace chat is displayed

What is the root cause of that problem?

This comes from #50278

We always navigate to the last accessed report here. In this case when we select Manage my team's expense, the policy expense chat is created and it's the last access report

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 85 to 88 in d93f29a

	const lastAccessedReportID = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID)?.reportID;
	if (!lastAccessedReportID) {
	return;
	}

What changes do you think we should make in order to solve the problem?

I checked and this logic is used when the user signs in with a public room. Then we can check if the lastAccessedReport is the report from the onboardingPolicyID we will navigate to concierge chat otherwise navigate to the last access report

const lastAccessedReport = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID);
const lastAccessedReportID = lastAccessedReport?.reportID
if (!lastAccessedReportID || lastAccessedReport?.policyID === onboardingPolicyID) {
    // We can return early or navigate to concierge here
    Report.navigateToConciergeChat();
    return;
}
const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID ?? '-1');
Navigation.navigate(lastAccessedReportRoute);

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 85 to 88 in d93f29a

	const lastAccessedReportID = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID)?.reportID;
	if (!lastAccessedReportID) {
	return;
	}

What alternative solutions did you explore? (Optional)

Or we can always navigate to the concierge chat as we do in the past

[allgandalf]

We are reverting the offending PR here: #50596

[ikevin127]

Given that the offending PR was reverted, this issue should be fixed - not an issue anymore.

[lakchote]

I'll close the issue, feel free to continue the discussion in it, it is just to clear up my K2.

@MarioExpensify please do not close it, as we still have a discussion ongoing and the problem hasn't found resolution yet.

If it's to clear up your K2, just unassign yourself. Thanks!

[lakchote]

@wildan-m yes I've been able to reproduce (on your original PR's branch):

Screen.Recording.2024-10-11.at.18.10.24.mov

[thesahindia]

Ok so it is reproducible when we test on the original PR branch, but after the new changes made by #49161 it's not reproducible anymore.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• (2nd) Fix long loading from public and redirect to last accessed report #50629

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @wildan-m requires payment (Needs manual offer from BZ)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @adelekennedy you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @wildan-m paid $(AMOUNT) via Upwork (LINK)
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1844427822228964480/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[wildan-m]

I'm sad about the penalty on the original issue #48715 but unsure if I qualify for payment in this one. Is resolving this part of the regression fix?

[lakchote]

@adelekennedy no payment is due here as it was a regression caused by @wildan-m's PR in #48715.

[adelekennedy]

sorry about that! Then I think we are good to close this one?

[melvin-bot]

@lakchote @adelekennedy Be sure to fill out the Contact List!