Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-26] [TS migration] Migrate 'Desktop' files to TypeScript #25333

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 18 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
desktop/start.js 3
desktop/notarize.js 2
desktop/main.js 12
desktop/dev.js 1
desktop/contextBridge.js 3
desktop/ELECTRON_EVENTS.js 0
desktop/dist/main.js 1138
desktop/dist/contextBridge.js 1
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01680fe7b11ae71f41
  • Upwork Job ID: 1775322712831635456
  • Last Price Increase: 2024-04-03
@Skalakid
Copy link
Contributor

Note for the future: Move ContextBridgeApi type to desktop/contextBridge.js when working on this issue.

@flodnv
Copy link
Contributor

flodnv commented Sep 20, 2023

Note: resolve this TODO: #27437 (review)

@fabioh8010
Copy link
Contributor

Updated List

Files

Path Dependencies
desktop/start.js 3
desktop/main.js 12
desktop/dev.js 1
desktop/contextBridge.js 3
desktop/ELECTRON_EVENTS.js 0

@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2023
Copy link
Author

melvin-bot bot commented Dec 4, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Dec 4, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Dec 4, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@melvin-bot melvin-bot bot reopened this Feb 9, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Mar 8, 2024
Copy link
Author

melvin-bot bot commented Mar 14, 2024

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 15, 2024
Copy link
Author

melvin-bot bot commented Mar 15, 2024

@mallenexpensify
Copy link
Contributor

PR was merged 2 days ago
#37615 (comment)

@getusha
Copy link
Contributor

getusha commented Mar 18, 2024

@mountiny could you assign me here for C+ payment?

@mountiny
Copy link
Contributor

$250 to @getusha

@mountiny mountiny added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Not a priority labels Mar 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 19, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Desktop' files to TypeScript [HOLD for payment 2024-03-26] [TS migration] Migrate 'Desktop' files to TypeScript Mar 19, 2024
Copy link
Author

melvin-bot bot commented Mar 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment (Needs manual offer from BZ)

Copy link
Author

melvin-bot bot commented Mar 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

@mallenexpensify bump for payment

@mallenexpensify mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Apr 3, 2024
Copy link
Author

melvin-bot bot commented Apr 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01680fe7b11ae71f41

Copy link
Author

melvin-bot bot commented Apr 3, 2024

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 labels Apr 3, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
@mallenexpensify
Copy link
Contributor

@getusha can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01680fe7b11ae71f41

@getusha
Copy link
Contributor

getusha commented Apr 3, 2024

@mallenexpensify accepted.

@mallenexpensify
Copy link
Contributor

Contributor+: @getusha paid $250 via Upwork (the job was originally listed at $500, TS migration jobs are $250)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

7 participants