-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$2000] When you long-press on a message, the message moves out of the screen frame and is hidden #10632
Comments
Triggered auto assignment to @marcaaron ( |
@marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick! |
What does this mean exactly... ? Looking at the video and I'm not even sure what the bug is. |
Also don't understand what is being proposed here. |
The problem is that once the context menu pops up and the modal blur is applied, it's not clear which message you've long-pressed on. What I was imagining is that the message you selected would have a white background / be "immune" from the modal blur effect. But I think a mockup would be very helpful here. @marcaaron suggested that we could use a "shimmer effect" as an alternative |
Triggered auto assignment to @michelle-thompson ( |
Yeah, that works! We'll also need to make sure that we:
|
Leaving you assigned so that you get the GH points @michelle-thompson |
Triggered auto assignment to @JmillsExpensify ( |
@hannojg @JmillsExpensify I think this problem can be fixed using |
📣 @kirillzyusko! 📣
|
Whoops, sorry missed this one. Sound great! |
Waiting to be picked up |
Contributor details |
This is being worked on in this PR: #16356 |
This has since moved to this PR: #42143 |
After switching to the new arch we've encountered a bug in reanimated on the fabric renderer. |
Hey @shawnborton, I left a message here to clarify this PR. I look forward to your answer |
Assigning myself to cover for Rory while he's on parental leave |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
When long pressing on the last message, we should adjust the scroll so that the message you just selected is visible.
Actual Result:
When you long-press on a message in iOS mobile, the message moves out of the screen frame and is hidden.
Workaround:
None
Platform:
Where is this issue occurring?
Version Number: 1.1.92-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
RPReplay_Final1661747398.MP4
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661612352759039
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: