Skip to content

Commit

Permalink
Merge pull request #50827 from Krishna2323/krishna2323/issue/49668
Browse files Browse the repository at this point in the history
fix: The Date options for Report Fields are ambiguous and should be updated.
  • Loading branch information
Julesssss authored Dec 3, 2024
2 parents d3d20f6 + 1d36289 commit b067baa
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/libs/WorkspaceReportFieldUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function getReportFieldInitialValue(reportField: PolicyReportField | null): stri
}

if (reportField.type === CONST.REPORT_FIELD_TYPES.DATE) {
return Localize.translateLocal('common.currentDate');
return Localize.translateLocal('common.initialValue');
}

return reportField.value ?? reportField.defaultValue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ function CreateReportFieldsPage({

{inputValues[INPUT_IDS.TYPE] === CONST.REPORT_FIELD_TYPES.DATE && (
<MenuItemWithTopDescription
title={translate('common.currentDate')}
title={translate('common.initialValue')}
description={translate('common.date')}
rightLabel={translate('common.required')}
interactive={false}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function ReportFieldsSettingsPage({
style={[styles.moneyRequestMenuItem]}
titleStyle={styles.flex1}
title={WorkspaceReportFieldUtils.getReportFieldInitialValue(reportField)}
description={translate('common.initialValue')}
description={translate('common.date')}
shouldShowRightIcon={!isDateFieldType && !hasAccountingConnections}
interactive={!isDateFieldType && !hasAccountingConnections}
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_REPORT_FIELDS_INITIAL_VALUE.getRoute(policyID, reportFieldID))}
Expand Down

0 comments on commit b067baa

Please sign in to comment.