Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concurrency issues in SourceDaoImpl.java #93

Open
nathanwalther opened this issue Jan 22, 2019 · 2 comments
Open

concurrency issues in SourceDaoImpl.java #93

nathanwalther opened this issue Jan 22, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@nathanwalther
Copy link
Member

Expected Behavior

Actual Behavior

Steps to Reproduce

Additional Information

We should look through SourceDaoImpl.java carefully for potential concurrency issues, and fix them accordingly.

This is based on code review rather than observing a defect happen, so I'm leaving the sections above blank.
@nathanwalther nathanwalther added the bug Something isn't working label Jan 22, 2019
@neoword
Copy link
Contributor

neoword commented Jan 27, 2019

@nathanwalther would be good for you to call out any specifics that you are looking for as an example / breadcrumb when someone decides to pick this up.

@nathanwalther
Copy link
Member Author

I'm worried about concurrent calls to upsert with the same stream name, particularly between these lines:

https://github.com/vinayakponangi/stream-registry/blob/a49e8cb365e3870243743d81e3ac2353e4d450c3/core/src/main/java/com/homeaway/streamplatform/streamregistry/db/dao/impl/SourceDaoImpl.java#L59-L61

The PR isn't merged yet, so I'm linking to the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neoword @nathanwalther