Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate possible dead code involving topicConfig #134

Open
neoword opened this issue Mar 2, 2019 · 1 comment
Open

Investigate possible dead code involving topicConfig #134

neoword opened this issue Mar 2, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@neoword
Copy link
Contributor

neoword commented Mar 2, 2019

Desired Behavior

See this possible dead code involving topicConfig.

https://github.com/homeaway/stream-registry/blob/553345fff8ed6997c1134820343ca6677ee4596b/core/src/main/java/com/homeaway/streamplatform/streamregistry/db/dao/AbstractDao.java#L160-L163

Seems like this code can be deleted and have no effect at all. If true, topicConfigMap argument is totally ignored.

Benefits

  • topicConfigMap won't be ignored and will be stored on various streams

Recommendation

  • If indeed ignored... remove from method signature and add new issue to support topicConfig at appropriate level (probably when bindings Stream /bindings are supported #31 are supported)
@neoword neoword added the enhancement New feature or request label Mar 2, 2019
@neoword
Copy link
Contributor Author

neoword commented Mar 2, 2019

cc: @prabhakar1983 can you investigate and provide a PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neoword