feat(initiate-deployment): output deployment id (#197)

ExpediaGroup · May 10, 2022 · 52c9f65 · 52c9f65
1 parent 5f729ee
commit 52c9f65
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 9 deletions.
diff --git a/dist/420.index.js b/dist/420.index.js
diff --git a/dist/420.index.js.map b/dist/420.index.js.map
diff --git a/src/helpers/initiate-deployment.ts b/src/helpers/initiate-deployment.ts
@@ -42,7 +42,7 @@ export const initiateDeployment = async ({
     ...GITHUB_OPTIONS
   });
   const deployment_id = (data as CreateDeploymentResponse).id;
-  return octokit.repos.createDeploymentStatus({
+  await octokit.repos.createDeploymentStatus({
     state,
     deployment_id,
     description,
@@ -51,4 +51,6 @@ export const initiateDeployment = async ({
     ...context.repo,
     ...GITHUB_OPTIONS
   });
+
+  return deployment_id;
 };
diff --git a/test/helpers/initiate-deployment.test.ts b/test/helpers/initiate-deployment.test.ts
@@ -44,16 +44,13 @@ describe('initiateDeployment', () => {
   const target_url = 'url';
   const auto_merge = false;
 
-  beforeEach(() => {
-    initiateDeployment({
+  it('should call createDeployment with correct params', async () => {
+    await initiateDeployment({
       sha,
       environment,
       description,
       target_url
     });
-  });
-
-  it('should call createDeployment with correct params', () => {
     expect(octokit.repos.createDeployment).toHaveBeenCalledWith({
       ref: sha,
       environment,
@@ -64,7 +61,13 @@ describe('initiateDeployment', () => {
     });
   });
 
-  it('should call createDeploymentStatus with correct params', () => {
+  it('should call createDeploymentStatus with correct params', async () => {
+    await initiateDeployment({
+      sha,
+      environment,
+      description,
+      target_url
+    });
     expect(octokit.repos.createDeploymentStatus).toHaveBeenCalledWith({
       state: 'in_progress',
       deployment_id,
@@ -74,4 +77,14 @@ describe('initiateDeployment', () => {
       ...GITHUB_OPTIONS
     });
   });
+
+  it('should return deployment id as output', async () => {
+    const result = await initiateDeployment({
+      sha,
+      environment,
+      description,
+      target_url
+    });
+    expect(result).toEqual(deployment_id);
+  });
 });