fix(notify-pipeline-complete): no longer set deployment status (#198)

src/helpers/notify-pipeline-complete.ts

@@ -11,11 +11,10 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { DEFAULT_PIPELINE_DESCRIPTION, DEFAULT_PIPELINE_STATUS, PRODUCTION_ENVIRONMENT } from '../constants';
+import { DEFAULT_PIPELINE_DESCRIPTION, DEFAULT_PIPELINE_STATUS } from '../constants';
 import { context as githubContext } from '@actions/github';
 import { map } from 'bluebird';
 import { octokit } from '../octokit';
-import { setDeploymentStatus } from './set-deployment-status';
 
 export class NotifyPipelineComplete {
   context?: string;
@@ -34,22 +33,14 @@ export const notifyPipelineComplete = async ({
     ...githubContext.repo
   });
   const commitHashes = data.map(pullRequest => pullRequest.head.sha);
-  return Promise.all([
-    map(commitHashes, async sha =>
-      octokit.repos.createCommitStatus({
-        sha,
-        context,
-        state: 'success',
-        description,
-        target_url,
-        ...githubContext.repo
-      })
-    ),
-    setDeploymentStatus({
-      description: DEFAULT_PIPELINE_DESCRIPTION,
-      environment: PRODUCTION_ENVIRONMENT,
+  return map(commitHashes, async sha =>
+    octokit.repos.createCommitStatus({
+      sha,
+      context,
       state: 'success',
+      description,
+      target_url,
       ...githubContext.repo
     })
-  ]);
+  );
 };

test/helpers/notify-pipeline-complete.test.ts

@@ -11,12 +11,11 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { DEFAULT_PIPELINE_DESCRIPTION, DEFAULT_PIPELINE_STATUS, PRODUCTION_ENVIRONMENT } from '../../src/constants';
+import { DEFAULT_PIPELINE_STATUS } from '../../src/constants';
 import { Mocktokit } from '../types';
 import { context } from '@actions/github';
 import { notifyPipelineComplete } from '../../src/helpers/notify-pipeline-complete';
 import { octokit } from '../../src/octokit';
-import { setDeploymentStatus } from '../../src/helpers/set-deployment-status';
 
 jest.mock('@actions/core');
 jest.mock('@actions/github', () => ({
@@ -72,13 +71,4 @@ describe('setOpenPullRequestStatus', () => {
       ...context.repo
     });
   });
-
-  it('should call setDeploymentStatus with correct params', () => {
-    expect(setDeploymentStatus).toHaveBeenCalledWith({
-      state: 'success',
-      environment: PRODUCTION_ENVIRONMENT,
-      description: DEFAULT_PIPELINE_DESCRIPTION,
-      ...context.repo
-    });
-  });
 });