From 6bafad769538ddbb1aa997a302e4207d7f65afb3 Mon Sep 17 00:00:00 2001 From: William Parsley Date: Mon, 4 Mar 2024 10:48:30 -0600 Subject: [PATCH] feedback --- go/internal/feast/featurestore.go | 9 ++++----- go/internal/feast/registry/repoconfig.go | 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/go/internal/feast/featurestore.go b/go/internal/feast/featurestore.go index b5ca8ecbfa..e3678cf409 100644 --- a/go/internal/feast/featurestore.go +++ b/go/internal/feast/featurestore.go @@ -56,12 +56,11 @@ func NewFeatureStore(config *registry.RepoConfig, callback transformation.Transf return nil, err } - if config.GoTransformationsEndpoint == "" && config.GoTransformationsServer { - return nil, errors.New("transformations server endpoint is missing") - } - var transformationService *transformation.GrpcTransformationService = nil - if config.GoTransformationsEndpoint != "" { + if config.GoTransformationsServer { + if config.GoTransformationsEndpoint == "" { + return nil, errors.New("Transformations server endpoint is missing. Update featue_store.yaml with go_transformations_endpint configuration") + } transformationService, _ = transformation.NewGrpcTransformationService(config, config.GoTransformationsEndpoint) } diff --git a/go/internal/feast/registry/repoconfig.go b/go/internal/feast/registry/repoconfig.go index 8caa3f262b..3b4e8d21eb 100644 --- a/go/internal/feast/registry/repoconfig.go +++ b/go/internal/feast/registry/repoconfig.go @@ -32,9 +32,10 @@ type RepoConfig struct { RepoPath string `json:"repo_path"` // EntityKeySerializationVersion EntityKeySerializationVersion int64 `json:"entity_key_serialization_version"` - // If false, use gopy bindings to calculate ODFV transformations + // If false, use gopy bindings to calculate ODFV transformations. + // "True" value required for Go feature server to serve ODFVs with stability and at scale. GoTransformationsServer bool `json:"go_transformations_server"` - // Transformation server base endpoint + // Transformation server base endpoint. GoTransformationsEndpoint string `json:"go_transformations_endpoint"` }