Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ad-hoc Bash reliant on local executables with TF resources #119

Open
rehevkor5 opened this issue Sep 25, 2019 · 3 comments
Open

Comments

@rehevkor5
Copy link

The TF stack currently relies on local execution of https://github.com/ExpediaGroup/apiary-data-lake/blob/master/scripts/mysql-user.sh which relies on local availability of aws, mysql, and jq executables.

This could be replaced by use of https://www.terraform.io/docs/providers/aws/d/secretsmanager_secret_version.html for AWS secret retrieval, and https://www.terraform.io/docs/providers/mysql/index.html for interacting with MySQL.

@massdosage
Copy link
Contributor

How much of an issue is this? Could we get a PR? I'm just trying to clean up issues which have been open for months with no movement on them.

@mroark1m
Copy link
Contributor

It is definitely a stumbling block to using the module... maybe we can at least doc it in the README for now?

@mroark1m
Copy link
Contributor

Here's a PR that updates the README (Ignore the "Issue 17" bit, I grabbed the wrong issue number): #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants