-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1477 Исправлен английский синоним для Консоль.КодировкаВыходногоПотока #1491
Conversation
WalkthroughThe pull request involves a modification to the Changes
Possibly related issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/OneScript.StandardLibrary/Text/ConsoleContext.cs (1)
Line range hint
160-171
: Update the documentation comment to reflect output encoding.The property attribute change looks good, but the documentation comment is incorrect as it describes input encoding instead of output encoding.
Apply this diff to fix the documentation:
/// <summary> -/// Возвращает или задает кодировку консоли, используемую при чтении входных данных. +/// Возвращает или задает кодировку консоли, используемую при выводе данных. /// </summary> /// <returns>КодировкаТекста</returns>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/OneScript.StandardLibrary/Text/ConsoleContext.cs
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: SonarQube
- GitHub Check: SonarQube
This comment has been minimized.
This comment has been minimized.
Вот, наконец-то масштабные полезные PR подвезли! 🥂 |
…Потока
Summary by CodeRabbit
OutputEncoding
property in theConsoleContext
class to clarify its role in managing console output encoding.