Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

everyvoice demo creates folders in an active directory #478

Open
wiitt opened this issue Jun 19, 2024 · 2 comments
Open

everyvoice demo creates folders in an active directory #478

wiitt opened this issue Jun 19, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@wiitt
Copy link
Collaborator

wiitt commented Jun 19, 2024

Running everyvoice demo creates logs_and_checkpoints and preprocessed/YourDataSet folders if they don't exist in a directory which had been active when the everyvoice demo command was activated.
Running speech synthesis in demo interface creates a synthesis_output folder with a wav folder and latest_predict_data.pth file in it.
Although demo doesn't save anything in the created folders, no folder creation should occur.

@wiitt wiitt added the bug Something isn't working label Jun 19, 2024
@wiitt wiitt added this to the beta milestone Jun 19, 2024
@joanise
Copy link
Member

joanise commented Nov 28, 2024

It looks like logs_and_checkpoints no longer gets created, which is good, but the synthesis_output folder still gets created when you synthesize stuff, with this contents:

synthesis_output/
├── latest_predict_data.pth
└── wav/

@joanise
Copy link
Member

joanise commented Nov 29, 2024

Here's another related bug, though: if you use -o, it's only half honoured:

Command: everyvoice demo -o foo ../fs2.ckpt ../voc.ckpt

File structure after synthesizing a file:

.
├── foo/
│   └── wav/
└── synthesis_output/
    └── latest_predict_data.pth

I think the desired behaviour is:

  1. by default, no output is created
  2. if -o is used, then maybe it's OK to create some output
  3. since no files ever actually get saved into wav/, it should not be created
  4. if it's relevant to create latest_predict_data.pth, it needs to be in the directory specified by -o, but I don't understand why that file gets saved, that probably should not happen, at least not by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants