-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Compose 1.17 fixed volumes override 🕊 #507
Comments
That's good news!! |
@michaelbaudino yeah i am aware of that, see laradock/laradock#1226 (comment) .. but i was not aware of the fix, thank you for informing use, awesome! |
@michaelbaudino not yet sure how we tackle this in the docs. The point is, having a mount in Anyway, i guess we have to wait a little to have the newest dc version spread so people can actually rely on it - or we add this in the docs as "if you want that, install dc from source" .. but this makes things complicated again i guess |
Wow good news ! |
I would like to notify everyone here that Docker Compose just fixed a bug where we could not override volumes with different modes. The fixed was released as part of version
1.17
.It's particularly useful to us (DockerSync users) because it will let us properly use the default (DockerSync-free) configuration in
docker-compose.yml
:And just put the DockerSync-specific stuff in another Docker Compose file (e.g.
docker-compose.override.yml
because it's automatically used when it exists):To be explicit: this configuration was failing prior to the above bugfix because of the
:nocopy
mode which was preventing a proper override.It means that DockerSync users can have their DockerSync configuration isolated (e.g. in afile ignored by git), and thus stop messing with the project configuration that could have been used by non-DockerSync users too.
DockerSync and not-DockerSync users shall now leave at peace again ❤️ 🕊 (even when working on the same project 🙏).
PS : should we document this somewhere? It looks to me that it should be a best practice (and probably even the default way to configure DockerSync).
PS2: TL;DR DockerCompose upgrade command (for MacOS, at least):
The text was updated successfully, but these errors were encountered: