Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and style correction #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

primercuervo
Copy link

In my last pull request I stated that the code for noc_block_chanmux was missing. Turns out that it is now called noc_block_channelizer, which I added in that same PR. Given that confusion, I went ahead and refactored the code slightly. This PR intends to:

  • Remove the taps_update python block, which was migrated to pure C++ and integrated into chanmux
  • Remove the unused boilerplate in rfnoc/fpga-srcs (that is, deleted the noc_block_chanmux instances there).
  • Applied verilog code guidelines for header and indentation
  • Removed precompiled headers
  • Various superfluous comment removal.

These commits can be squashed if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant