Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Refactor code base #132

Closed
3 tasks
kgonzago opened this issue Jan 8, 2018 · 7 comments
Closed
3 tasks

Refactor code base #132

kgonzago opened this issue Jan 8, 2018 · 7 comments

Comments

@kgonzago
Copy link
Contributor

kgonzago commented Jan 8, 2018

Before the GRG widget can be added to the WAB code base to have it included in the pool of core widgets for 6.1 release, we will need to review the widget from code and UI perspectives. Below is a list of high-level topics that will guide this epic:

@kgonzago kgonzago added the Epic label Jan 8, 2018
@lfunkhouser
Copy link
Member

@kgonzago please provide more information on what this means.

@kgonzago kgonzago changed the title Refactor code Refactor code base Jan 9, 2018
This was referenced Jan 9, 2018
@kgonzago
Copy link
Contributor Author

kgonzago commented Jan 9, 2018

@lfunkhouser @topowright, I added additional information to this epic and tied four issues to it. Hopefully, what I added will be sufficient to remove any confusion. Let me know if more info is needed.

@adgiles Please add to this epic if I missed something.

@topowright-zz
Copy link
Contributor

@adgiles is this still needed being that we are now further along in the process?

@adgiles
Copy link
Contributor

adgiles commented Jan 30, 2018

@topowright no refactoring of the code base has taken place

@kgonzago
Copy link
Contributor Author

kgonzago commented Jan 30, 2018

Looks like it is not needed since Junshan already completed his initial code review without a comment regarding code refactoring.

@kgonzago
Copy link
Contributor Author

We can close out this epic or temporarily place it on the back burner.

@lfunkhouser
Copy link
Member

Closing. Will create a new issue/epic if this is required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants