This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor code base #132
Comments
@kgonzago please provide more information on what this means. |
This was referenced Jan 9, 2018
Open
@lfunkhouser @topowright, I added additional information to this epic and tied four issues to it. Hopefully, what I added will be sufficient to remove any confusion. Let me know if more info is needed. @adgiles Please add to this epic if I missed something. |
@adgiles is this still needed being that we are now further along in the process? |
@topowright no refactoring of the code base has taken place |
Looks like it is not needed since Junshan already completed his initial code review without a comment regarding code refactoring. |
We can close out this epic or temporarily place it on the back burner. |
Closing. Will create a new issue/epic if this is required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Before the GRG widget can be added to the WAB code base to have it included in the pool of core widgets for 6.1 release, we will need to review the widget from code and UI perspectives. Below is a list of high-level topics that will guide this epic:
The code base will need to be refactored before its inclusion into core WAB. This is captured in Refactor Widget.js #131 and Reduce the amount of JS files #138.
We want to promote code readability and also adhere to best practices for JS coding (coding guidelines from JS Dev Team). This is captured in Review code base #136.
Review UI and determine if it adheres to WAB design guidelines. This is captured in Review UI #137.
The text was updated successfully, but these errors were encountered: