-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L.esri.LabelLayer #916
Comments
@jgravois made a sweet prototype http://jsbin.com/matufo/edit?html,output using https://github.com/Geovation/labelgun |
@patrickarlt I just talked with @jgravois that I can try to PR this issue as a weekend project. |
Take about couple hours on this, and I need you guys helps to look at this issues that I run into.
And I saw @patrickarlt mentioned this related issue on here: rollup/rollup#220 PS: Talked with @jgravois and not sure do we suppose to change anything here to make it load the new add "LabelLayer.js" file? When I add this line "export { LabelLayer } from './Layers/LabelLayer/LabelLayer';" Would you guys provide some helps about how to make it load correctly? |
i have a couple suggestions:
just assuming UMD module etc. etc. |
@jgravois Thanks for the suggestions. Based on this heatmap example: https://github.com/Esri/esri-leaflet-heatmap/blob/master/src/HeatmapFeatureLayer.js We still need to add this HeatmapFeatureLayer.js and how could we debug to make sure this file is loaded? |
take a look at esri-leaflet-heatmap/debug/sample.html calling the build process is only necessary because the plugin is written in ES6. |
Creating label layer would be fairly easy using something like https://github.com/Geovation/labelgun or https://github.com/MazeMap/Leaflet.LayerGroup.Collision as a new plugin.
The text was updated successfully, but these errors were encountered: