Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS #598

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

prathameshnarkhede
Copy link
Contributor

@prathameshnarkhede prathameshnarkhede commented Aug 28, 2024

The bug is related to Bookmarks updating template does not apply on all rows for iOS.

MAUI Bug Reported dotnet/maui#24492

EDIT:
Found that changing to CollectionView actually solves this issue and I was able to test it on Windows, iOS and Android platforms.
There is going to be a breaking change for ItemTemplates Cells used for CollectionView.

@prathameshnarkhede prathameshnarkhede changed the title Documented known MAUI iOS issue in ItemTemplateChanged Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS Aug 30, 2024
- This Fixes a bug with Android adding item couple of times when new Bookmark is added.
- Centralize the update logic for the CollectionView in the BookmarksView class by introducing a new `UpdateListView` method.
@prathameshnarkhede prathameshnarkhede changed the title Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS Sep 4, 2024
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggested changes, you don't need the method UpdatePresentingView() at all.

src/Toolkit/Toolkit.Maui/BookmarksView/BookmarksView.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit.Maui/BookmarksView/BookmarksView.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit.Maui/BookmarksView/BookmarksView.cs Outdated Show resolved Hide resolved
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

@prathameshnarkhede prathameshnarkhede merged commit 50b0659 into main Sep 5, 2024
1 check passed
@prathameshnarkhede prathameshnarkhede deleted the pratham/bookmarksview-ios-bug branch September 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants