Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: Refactor use of SlashCommands to Commands for upcoming D#+ deprecation #202

Open
Erisa opened this issue Jun 27, 2024 · 1 comment · May be fixed by #243
Open

Todo: Refactor use of SlashCommands to Commands for upcoming D#+ deprecation #202

Erisa opened this issue Jun 27, 2024 · 1 comment · May be fixed by #243
Assignees
Labels
help wanted Extra attention is needed interaction commands

Comments

@Erisa
Copy link
Owner

Erisa commented Jun 27, 2024

https://dsharpplus.github.io/DSharpPlus/articles/migration/slashcommands_to_commands.html

@Erisa Erisa added the help wanted Extra attention is needed label Jun 27, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Cliptok todo Jun 27, 2024
@Erisa Erisa moved this from Backlog to Planned in Cliptok todo Jul 12, 2024
@Erisa Erisa moved this from Planned to Backlog in Cliptok todo Jul 28, 2024
@FloatingMilkshake FloatingMilkshake self-assigned this Sep 20, 2024
@FloatingMilkshake FloatingMilkshake moved this from Backlog to In Progress in Cliptok todo Sep 20, 2024
@FloatingMilkshake
Copy link
Collaborator

Currently I have updated to DSharpPlus 5.0.0-nightly-02379. DSharpPlus.SlashCommands and DSharpPlus.CommandsNext have been migrated to DSharpPlus.Commands, and each individual command processor (text command processor and slash command processor) function. However, they don't function together yet.

Lots of our commands are both text and slash commands. For some, everything is the same and they can be combined into a single command under DSharpPlus.Commands (I haven't done this yet! But it will be done before this is considered complete). Some commands cannot be easily-combined like this. For example, we have different usages between !ban and /ban. I do not want to change the usage of either of them (though if I have to, the text command takes priority!).

DSharpPlus.Commands does not currently allow us to register both a slash and text command with the same name (looks to be maybe planned?). This issue is "blocked" on that. See some discussion at https://discord.com/channels/150662382874525696/793285213823172628/1291774345558884523 and https://discord.com/channels/379378609942560770/1094835363475886163/1290285210247761972

@Erisa Erisa added the blocked-on-dsharpplus requires changes from dsharpplus to proceed label Oct 25, 2024
@FloatingMilkshake FloatingMilkshake removed the blocked-on-dsharpplus requires changes from dsharpplus to proceed label Nov 15, 2024
@FloatingMilkshake FloatingMilkshake linked a pull request Nov 20, 2024 that will close this issue
@Erisa Erisa moved this from In Progress to Awaiting review in Cliptok todo Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed interaction commands
Projects
Status: Awaiting review
Development

Successfully merging a pull request may close this issue.

2 participants