-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove errant WinSCP entry #76
Comments
When I was testing pull commit #67 I had to use Other for the DEFAULT (System Installation) hive as DEFAULT didn't work so this was purposeful. Has this changed? |
Ah that's news to me. I'll have to test, I guess. I don't think I know anything about the DEFAULT hive but it's not hard to make a quick test batch file. I saw your PR but didn't realize Other was the workaround to that! |
I tested it there now with DEFAULT
With Other
I agree with you it is odd but I did try and modify the code to add the DEFAULT type as an option but it didn't work hence I went with the Other option as a workaround. For testing installing to SYSTEM if you want to experiment I use Process Hacker and go to the Hacker menu Run As and do this. Expect errors though and weird program behaviours. I got errors in the installer of WinSCP when I tested it but I clicked through ignored them and it still worked. |
Good stuff. Thank you for the information! At least right now, the DFIRBatch file is functional and passing validation. We can always re-add once we figure out if Other or DEFAULT will be the path forward. @reece394, fair to say #67 didn't take as expected, then? If needed, we may want to tag @EricZimmerman on this. I can also try to take a peek. At least a workaround is to just use |
Well #67 was only to make RECmd actually see the DEFAULT registry when not specifically specifying it i.e not using -f default but using -d so in that regard it works as intended. But yeah it depends on if Eric wants to have a specific type for DEFAULT to avoid collisions if there are other registry hives I haven’t been considering . For my needs I was happy enough to use Other but I can understand if this isn’t acceptable. |
IMHO if it works, let's just roll with it. Less work on Eric's part and we'll just want to ensure proper documentation exists somewhere that |
RECmd/BatchExamples/DFIRBatch.reb
Lines 2594 to 2600 in ce986df
Other
hive is not validThe text was updated successfully, but these errors were encountered: