Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot to instantiate the rng. #151

Open
jgh9094 opened this issue Sep 18, 2024 · 2 comments
Open

Forgot to instantiate the rng. #151

jgh9094 opened this issue Sep 18, 2024 · 2 comments
Assignees

Comments

@jgh9094
Copy link
Contributor

jgh9094 commented Sep 18, 2024

https://github.com/EpistasisLab/tpot2/blob/8ebc82cb3b4d6fadfa5228a7de3134a9edc59acb/tpot2/search_spaces/nodes/estimator_node_gradual.py#L55C1-L56C1

We are forgetting to add 'rng = np.random.default_rng(rng)' to instantiate a new or old rng.

@perib perib self-assigned this Sep 18, 2024
@perib
Copy link
Collaborator

perib commented Sep 18, 2024

this is technically not needed since it is handled by the gradual_hyperparameter_update function where the rng is used. but we could just have an extra check for clarity?

@jgh9094
Copy link
Contributor Author

jgh9094 commented Sep 18, 2024

That's a good point, we don't need to instantiate the rng in the mutation function since we don't do anything with it!

@perib perib mentioned this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants