Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom handler for ptr_to_array runtime call #2258

Merged
merged 3 commits into from
Jan 9, 2025
Merged

add custom handler for ptr_to_array runtime call #2258

merged 3 commits into from
Jan 9, 2025

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jan 8, 2025 •
edited
Loading

fixes #2257

@vchuravy vchuravy requested a review from wsmoses January 8, 2025 13:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Benchmark Results

main f37271c... main/f37271c46173b8...
basics/overhead 4.33 ± 0.01 ns 4.64 ± 0.01 ns 0.933
time_to_load 1.13 ± 0.007 s 1.13 ± 0.0058 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@vchuravy
Copy link
Member Author

vchuravy commented Jan 9, 2025

Is the CI failure

Stored value type does not match pointer operand type!
  store {} addrspace(10)* @ejl_jl_nothing, {}** %15, align 8, !noalias !376
 {} addrspace(10)*Stored value type does not match pointer operand type!
  store {} addrspace(10)* @ejl_jl_nothing, {}** %16, align 8, !noalias !376
 {} addrspace(10)*julia: /home/runner/work/Enzyme.jl/Enzyme.jl/julia/src/llvm-remove-addrspaces.cpp:471: llvm::PreservedAnalyses RemoveAddrspacesPass::run(llvm::Module&, llvm::ModuleAnalysisManager&): Assertion `!verifyModule(M, &errs())' failed.

[14414] signal (6.-6): Aborted
in expression starting at /home/runner/work/Enzyme.jl/Enzyme.jl/test/runtests.jl:251
gsignal at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7f571b2ca728)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
run at /home/runner/work/Enzyme.jl/Enzyme.jl/julia/src/llvm-remove-addrspaces.cpp:471
run at /home/runner/work/Enzyme.jl/Enzyme.jl/julia/src/llvm-remove-addrspaces.cpp:514

on 1.10 going to be fixed by 1.10.8?

@wsmoses
Copy link
Member

wsmoses commented Jan 9, 2025

I don't think so, but it would definitely be nice.

I tried to determine what in Julia was going wrong with that to no avail and got distracted by other things

@wsmoses wsmoses merged commit 8a0bff4 into main Jan 9, 2025
21 of 29 checks passed
@wsmoses wsmoses deleted the vc/ptr_to_array branch January 9, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing derivative rule for ptr_to_array & co.
2 participants
@vchuravy @wsmoses