-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Julia formatter #1326
Add Julia formatter #1326
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
===========================================
- Coverage 93.54% 74.51% -19.04%
===========================================
Files 7 35 +28
Lines 248 10811 +10563
===========================================
+ Hits 232 8056 +7824
- Misses 16 2755 +2739 ☔ View full report in Codecov by Sentry. |
There is an issue with permissions, probably requires admin permissions to fix. |
julia -e 'using Pkg; Pkg.add("JuliaFormatter")' | ||
julia -e 'using JuliaFormatter; format("."; verbose=true)' | ||
- uses: reviewdog/action-suggester@v1 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with: | |
with: | |
github_token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simsurace did you intend to remove this when you force pushed?
8c2cc7c
to
61d4b3b
Compare
Can we merge the Formatter on its own and slowly apply the suggested changes? Right now this will cause large conflicts with other PRs. I think |
Sure thing. |
a4c62f3
to
3cc48bd
Compare
Thanks! Lets see how this does and if it is to annoying we may disable it. |
How is it gonna work to get the codebase formatted now? |
As an example see #1302 where the changes themselves will be formatted. So slowly over time the code base will match the format rules, but without the cost of having large merge conflicts with existing PRs |
Ok. Might take a very long time to traverse the entire code base, but we could still format the other files separately. But e.g. in #1307 the action still fails due to permissions. |
Maybe this will help a bit with readability.