Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biganimal_region resources should be renamed as biganimal_regions #131

Open
serdardalgic opened this issue Feb 8, 2023 · 0 comments
Open
Labels
bug Something isn't working go Pull requests that update Go code needs_major_bump Issues or Pull requests that need a major version bump

Comments

@serdardalgic
Copy link
Contributor

serdardalgic commented Feb 8, 2023

Although it's returning a List, the name of the data-source is singular.

That's against our Naming Conventions.

Changing this would be a breaking change. Please refer to Provider Data Source or Resource Rename Documentation for further details. Quoting there:

When renaming a resource from one name to another, it is important to keep backwards compatibility with both existing Terraform configurations and the Terraform state while operators migrate. To accomplish this, there will be some duplicated logic to support both resources until the next MAJOR release. Once both resources are appropriately handled, the process for deprecating and removing the old resource is the same as noted in the Provider Data Source or Resource Removal section.


As of 21st of April, 2023; some more thinking on this ticket:

A possible solution would be

  • creating a new data source called biganimal_regions
  • marking biganimal_region as will be deprecated in the next major bump, please use biganimal_regions data source instead
  • In the next major bump, we deprecate biganimal_region
@serdardalgic serdardalgic added bug Something isn't working go Pull requests that update Go code needs_major_bump Issues or Pull requests that need a major version bump labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code needs_major_bump Issues or Pull requests that need a major version bump
Projects
None yet
Development

No branches or pull requests

1 participant