Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the connection string code in biganimal_cluster resource/data-sources #114

Open
serdardalgic opened this issue Jan 12, 2023 · 0 comments
Open

Refactor the connection string code in biganimal_cluster resource/data-sources #114

serdardalgic opened this issue Jan 12, 2023 · 0 comments
Labels
go Pull requests that update Go code good first issue Good for newcomers

Comments

@serdardalgic
Copy link
Contributor

serdardalgic commented Jan 12, 2023 •
edited
Loading

After the successful merge of #113 , we can refactor the way we're getting the connection string.
We don't need to call the clusters/<cluster_id>/connection/ endpoint anymore because this information is coming with the cluster in API v3, in connection field.

Instead of calling this function separately in the data-source and the resource, we can utils.SetOrPanic the cluster.ClusterConnection, or something similar.
@serdardalgic serdardalgic added good first issue Good for newcomers go Pull requests that update Go code labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serdardalgic