Edits to Fix default setting and type for force_full_mesh. #6188 #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebgitelman
commented
Nov 15, 2024
ebgitelman
commented
Nov 15, 2024
| @@ -32,42 +32,44 @@ The write leader nodes in other non-subscriber-only groups replicate changes to | |||
|
|
|||
There was a problem hiding this comment.
In the para before this section head, I wanted to check whether the second sentence needed some additional punctuation or if there was some error, as it seemed to contradict itself.
There was a problem hiding this comment.
Have made changes to make it clearer.
ebgitelman
commented
Nov 15, 2024
djw-m
reviewed
Nov 18, 2024
product_docs/docs/pgd/5.6/nodes/subscriber_only/optimizing-so.mdx
Outdated
Show resolved
Hide resolved
djw-m
approved these changes
Nov 18, 2024
| @@ -32,42 +32,44 @@ The write leader nodes in other non-subscriber-only groups replicate changes to | |||
|
|
|||
There was a problem hiding this comment.
Have made changes to make it clearer.
Co-authored-by: Dj Walker-Morgan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?