Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow move/purge commands to take a message id as argument, instead of number of messages #153

Open
tehhowch opened this issue Jan 23, 2019 · 4 comments

Comments

@tehhowch
Copy link
Collaborator

Counting is dumb. And error-prone. Instead, James should find the message referenced, and operate on the messages between then and the command

@tehhowch
Copy link
Collaborator Author

I'm gonna have to put my Java hat back on aren't i

@MCOfficer
Copy link
Member

possibly. i planned on migrating to JDA4 soon, so if you ask nicely, this looks doable. i just need motivation..

@tehhowch
Copy link
Collaborator Author

would it make sense to provide named arguments too, e.g. these could both be valid:

-move <channel> --after=<messageId> --until=<messageId>
-move <channel> <count> --after=<messageId>

I'd need to investigate the arg parsing a bit but it seems not difficult and possibly easier for mods

@MCOfficer
Copy link
Member

MCOfficer commented Sep 29, 2019

i tried to get by without unix-style arguments so far, because they seem to be unintuitive for non-linux users. in this case, you can still use positional arguments and infer their meaning from context, though that may be pretty confusing, too.

the simple alternative is to simply make command aliases, e.g. -moverange, -moveafter, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants