-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fees get paid even opening tx for swap fails #324
Comments
confirmed, same error from Zap-O-Matic initiating a LN -> LBTC swap with Strike. It looks like their LBTC wallet is locked, but we only know about it after sending the 300 sats. Would expect either the pre-payment is conducted after an initial check with the node to ensure their wallet is ready, or that the fee is bounced back after this particular kind of failure in which the fee is not spent. |
Thank you for reporting the issue. A Line 382 in b7070ca
However, since this check alone may not be sufficient in some cases, I am considering updating the process as follows:
I thik these improvements will reduce the risk. Points to NoteHowever, even with this approach, it does not completely prevent cases where only prepayment is received and then a swap cancellation occurs afterward. For such abuse cases, there is already a mechanism within the system that records as "suspicious peer." |
I just created a swap with strike and got an error message from their side:
this already happend in the past but I didnt realize it that time, now I see theres defintiv a bug, or a missbevavior as ps shouldnt pay fees if the swap might fail.
PS probably needs a pre-check to validate that the swap would work.
maybe @Impa10r and @zapomatic can explain it better, because they also experience this bug already.
The text was updated successfully, but these errors were encountered: