From d10f33bea6af89135580b464310e1eb5c4f2f713 Mon Sep 17 00:00:00 2001 From: Vincenzo Palazzo Date: Fri, 20 Oct 2023 08:56:08 +0200 Subject: [PATCH] libhsmd: removing assertion on push_value The assertion may not make sense if we change the meaning of `push_value` to be relative, especially since negative values appear as large positive. Suggested-by: Ken Sedgwick Signed-off-by: Vincenzo Palazzo --- hsmd/libhsmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hsmd/libhsmd.c b/hsmd/libhsmd.c index 800495c5f0e1..a004bc63b609 100644 --- a/hsmd/libhsmd.c +++ b/hsmd/libhsmd.c @@ -373,7 +373,6 @@ static u8 *handle_ready_channel(struct hsmd_client *c, const u8 *msg_in) /* Fail fast if any values are uninitialized or obviously wrong. */ assert(amount_sat_greater(channel_value, AMOUNT_SAT(0))); assert(amount_sat_to_msat(&value_msat, channel_value)); - assert(amount_msat_less_eq(push_value, value_msat)); assert(!mem_is_zero(&funding_txid, sizeof(funding_txid))); assert(local_to_self_delay > 0); assert(remote_to_self_delay > 0);