This repository has been archived by the owner on May 13, 2024. It is now read-only.
Add Code Style Guidelines and Linter/Formatter #62
Labels
good first issue
Good for newcomers
Milestone
Comments
15 tasks
AddressXception
added a commit
that referenced
this issue
Jan 27, 2020
add an underscore prefix to static coordinator instance handles to differentiate vars until #62 is complete
echumley-msft
pushed a commit
that referenced
this issue
Jan 28, 2020
* Support external_ballot_identifer as a string. Export/import ballots from encrypter Add support for encrypter to export ballots to the file system. Import encrypter ballots into coordinator. Add a hashtable implementation that tracks ballot cast/spoil state against the external identifier (ballot_collection.c). Support loading ballots into a buffer. Fix memory leaks in bignum.c, crypto.c, decryption/coordinator.c, decryption/trustee.c, voting/coordinator.c, voting/encrypter.c, etc. Rework the API example to demonstrate the new external id and file system changes. Improve debug logging. Add more api documentation. Modify MAX_BALLOT_PAYLOAD to 2000. Explicitly add // TODO: to track remaining work. Note this commit is a work in progress and currently breaks the simple example. * Remove Simple Example, add api doc stubs Add stubs for the api documentation. Remove the simple example and use the api sample in the PR pipeline workflow * Fix Merge Issue * Verify malloc success * Address PR Feedback * Fix LGTM alerts * Add soft delete of encrypter files * Free CP Proof * Fix windows Makefile * test fix pr workflow on windows * use secure api's * explicitly compile release * flush file write before read * clean up makefile * Document consumers resonsible for free when calling an api that generates a filename as an out parameter, the caller is responsible for managing the memory of the out parameter when the call is successful * Rename static coordinators in API to differentiate local vars add an underscore prefix to static coordinator instance handles to differentiate vars until #62 is complete * add new enum cases to the end on voting coordinator * Add convenience logging * Handle error cases on file access use convenience logging * use consistent file formatting when rebuilding tracker string * optimize null check * explicitly set tracker array positions to NULL on failure * Reformat refactor Decryption_Coordinator_receive_share * guard tallies_initialized when freeing resources explicitly initialize num_tallies * rename _encrypted_ballot_count * don't return early * do not fail soft delete if rename fails * fix assignment * adjust number of ballots to force a rebuild
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Request
Is your feature request related to a problem? Please describe.
File formatting is inconsistent in the code which reduces readability. We should enforce code style guidelines with a tool
Describe the solution you'd like
Adding a linter or formatter to the CI pipeline and that can be executed locally.
The text was updated successfully, but these errors were encountered: